Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): adds sql support #129

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

bc-chaz
Copy link
Contributor

@bc-chaz bc-chaz commented Sep 23, 2022

What?

Adds mysql support to the checkout reference application.

Why?

Needed for release

Testing / Proof

deployed to Heroku, verified clearDB populated with correct checkout and plan info. Also ran linting, tests, and confirmed build.

@bigcommerce/api-client-developers

lib/dbs/mysql.ts Outdated Show resolved Hide resolved
@bookernath bookernath temporarily deployed to billing-test-app-stg-50fixed September 26, 2022 21:05 Inactive
@bookernath bookernath temporarily deployed to billing-test-app-stg-30rec September 26, 2022 21:07 Inactive
scripts/db.js Outdated Show resolved Hide resolved
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, next reasonable iteration would be to introduce an ORM so we don't have to mess with raw SQL so much

@bc-chaz bc-chaz merged commit 5f8f7e2 into bigcommerce:automated-billing-beta Sep 27, 2022
@bc-chaz bc-chaz deleted the appex-399 branch September 27, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants