Skip to content

Commit

Permalink
Merge pull request #109 from bc-chaz/appex-336
Browse files Browse the repository at this point in the history
feat(common): update node, big-design, and jest to latest
  • Loading branch information
bc-chaz authored Jul 12, 2022
2 parents b9ee006 + 7f55ee2 commit 295580a
Show file tree
Hide file tree
Showing 12 changed files with 15,323 additions and 1,443 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/validate-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x, 18.x]

steps:
- name: Checkout code
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
14
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This demo includes all of the files necessary to get started with a basic, hello

To get the app running locally, follow these instructions:

1. [Use Node 12+ and NPM 7+](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm#checking-your-version-of-npm-and-node-js)
1. [Use Node 14+ and NPM 7+](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm#checking-your-version-of-npm-and-node-js)
2. Install npm packages
- `npm install`
3. [Add and start ngrok.](https://www.npmjs.com/package/ngrok#usage) Note: use port 3000 to match Next's server.
Expand Down
4 changes: 2 additions & 2 deletions components/form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const Form = ({ formData, onCancel, onSubmit }: FormProps) => {
const [errors, setErrors] = useState<StringKeyValue>({});

const handleChange = (event: ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
const { name: formName, value } = event?.target;
const { name: formName, value } = event.target || {};
setForm(prevForm => ({ ...prevForm, [formName]: value }));

// Add error if it exists in FormErrors and the input is empty, otherwise remove from errors
Expand All @@ -33,7 +33,7 @@ const Form = ({ formData, onCancel, onSubmit }: FormProps) => {
};

const handleCheckboxChange = (event: ChangeEvent<HTMLInputElement>) => {
const { checked, name: formName } = event?.target;
const { checked, name: formName } = event.target || {};
setForm(prevForm => ({ ...prevForm, [formName]: checked }));
};

Expand Down
4 changes: 2 additions & 2 deletions components/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ const Header = () => {
});

const items = [
{ id: TabIds.HOME, title: 'Home' },
{ id: TabIds.PRODUCTS, title: 'Products' },
{ ariaControls: 'home', id: TabIds.HOME, title: 'Home' },
{ ariaControls: 'products', id: TabIds.PRODUCTS, title: 'Products' },
];

const handleTabClick = (tabId: string) => {
Expand Down
Loading

0 comments on commit 295580a

Please sign in to comment.