Add body as a callback support to 4.2.4. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/output (cherry picked from commit 0e79b79)
(cherry picked from commit 161dd98)
(cherry picked from commit a849fd6)
…se when is a callback function (cherry picked from commit a95cb49)
(cherry picked from commit 78c34ba)
… doesn't fail in common cases; MessageTest: use echo rather then complicated fwrite to php://output (cherry picked from commit f065bd5)
(cherry picked from commit 4b6fef9)
|
ping @philipmuir @gwilym |
|
Is there much that can be done about running a custom fork of this? How divergent are we? |
|
The changes that we require are only available in master and as an alpha 5.0 release - https://github.com/sabre-io/http/releases. Perhaps in the future when its stable we can get rid of this fork. |
xyzjace
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings Petr's changes from sabre-io#65 into a branch based off the 4.2.4 release.
It also brings in this commit which bumps the dependencies - 4b6fef9
We currently have all these changes in the custom tag 4.2.1.2 - https://github.com/bigcommerce-labs/sabre-http/releases/tag/4.2.1.2.
I've re-authored the commits to keep them as the head of the branch.
Updating this component will bring us a much needed fix - sabre-io#73 - which should resolve - https://rpm.newrelic.com/accounts/44889/applications/4757985/traced_errors/4dca0f16-5188-11e8-b482-0242ac11000f_18714_21831 - which has the highest number of reported errors on production.
https://jira.bigcommerce.com/browse/BIG-30701
This will also allow us to bring the main sabre/dav library up to date (we're also running a custom tag which also has changes from Petr).