Revert some unused code #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not used anywhere and should be reverted as part of the overall reversion related to GraalVM
Revert refactor that exposed setLanguage function
Revert changes to translation compilation error handling leftover from failed MessageFormat upgrade
jairo-bc
approved these changes
Jan 26, 2022
| this.setLanguage(languages); | ||
| /** | ||
| * @private | ||
| * @type {Object.<string, string>} |
There was a problem hiding this comment.
I think you don't need those statements here anymore
There was a problem hiding this comment.
I'm just reverting back to what it was - if we want to remove these, let's do it consistently for all of them in a separate change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert some changes over the past year that are unused or related to other reversions.
preprocessandaddTemplateswhich are unusedsetLanguagefunction which is unused outside ofTranslatorclassTranslator.compileFormatterFunction