Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-398 Make every product option group id unique #1979

Merged
merged 2 commits into from
Feb 9, 2021
Merged

fix(storefront): BCTHEME-398 Make every product option group id unique #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a894564
fix(storefront): BCTHEME-398 Make every product option group id unique
BC-tymurbiedukhin Feb 8, 2021
c96df0d
Merge branch 'master' into BCTHEME-398
BC-tymurbiedukhin Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Changelog

- Fixed required checkbox message displaying. [1963](https://github.com/bigcommerce/cornerstone/pull/1963)

## Draft
- Make every product option group id unique. [#1979](https://github.com/bigcommerce/cornerstone/pull/1979)
- Fixed required checkbox message displaying. [1963](https://github.com/bigcommerce/cornerstone/pull/1963)
- Provided sufficient & informative text along with the color swatches [#1976](https://github.com/bigcommerce/cornerstone/pull/1976)
- If multiple Pick List Options are applied, customers cannot select "none" on both. [#1975](https://github.com/bigcommerce/cornerstone/pull/1975)
- Moved phrase from compare.html to en.json for increasing localization. [#1972](https://github.com/bigcommerce/cornerstone/pull/1972)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/options/set-radio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="form-field" data-product-attribute="set-radio" role="radiogroup" aria-labelledby="radio-group-label">
<label class="form-label form-label--alternate form-label--inlineSmall" id="radio-group-label">
<div class="form-field" data-product-attribute="set-radio" role="radiogroup" aria-labelledby="radio-group-label-{{id}}">
<label class="form-label form-label--alternate form-label--inlineSmall" id="radio-group-label-{{id}}">
{{ this.display_name }}:

{{> components/common/requireness-msg}}
Expand Down