fix(bctheme): BCTHEME-57 Cornerstone - No '0 Products Matched' messag… #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in Faceted Search
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
reviewed
Jul 10, 2020
| {{> components/common/paginator pagination.category}} | ||
| {{else}} | ||
| <p>{{lang 'categories.no_products'}}</p> | ||
| {{/if}} |
There was a problem hiding this comment.
EOL has been added
junedkazi
previously approved these changes
Jul 10, 2020
BC-tymurbiedukhin
dismissed stale reviews from junedkazi and golcinho
via
fc1f9d6
|
@golcinho @junedkazi pr needs approve one more time, thank you) |
golcinho
approved these changes
Jul 13, 2020
junedkazi
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e in Faceted Search
What?
When you perform a faceted search that returns zero products you just get an empty page. There is a feature request to add No Products Found messaging to cornerstone
#1421
Tickets / Documentation
https://jira.bigcommerce.com/browse/BCTHEME-57
Screenshots (if appropriate)
ping @yurytut1993 @golcinho @bc-alexsaiannyi