Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): modify cart page layout for mobile view #896

Merged
merged 1 commit into from
May 10, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Modified cart page layout to better account for mobile viewport.

Screenshot 2024-05-10 at 12 27 56 PM

Screenshot 2024-05-10 at 12 28 07 PM

Screenshot 2024-05-10 at 12 28 15 PM

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner May 10, 2024 17:35
Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 0111324

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 5:36pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) May 10, 2024 5:36pm
catalyst-au ⬜️ Ignored (Inspect) May 10, 2024 5:36pm
catalyst-test-store ⬜️ Ignored (Inspect) May 10, 2024 5:36pm
catalyst-uk ⬜️ Ignored (Inspect) May 10, 2024 5:36pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-32kyhielr-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit b13fecf May 10, 2024
11 checks passed
@jorgemoya jorgemoya deleted the change-cart-mobile branch May 10, 2024 19:37
This was referenced May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants