Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply the edge runtime to missing routes #786

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Apply the edge runtime to missing routes.

Testing

Before

Screenshot 2024-04-17 at 16 03 20

After

Screenshot 2024-04-17 at 16 03 26

@chanceaclark chanceaclark requested a review from a team as a code owner April 17, 2024 20:06
Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: b3b4779

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 8:07pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 8:07pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Apr 17, 2024 8:07pm
catalyst-au ⬜️ Ignored (Inspect) Apr 17, 2024 8:07pm
catalyst-storybook ⬜️ Ignored (Inspect) Apr 17, 2024 8:07pm
catalyst-uk ⬜️ Ignored (Inspect) Apr 17, 2024 8:07pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-e992514kf-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

@chanceaclark chanceaclark added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 8e6328f Apr 17, 2024
15 checks passed
@chanceaclark chanceaclark deleted the fix/runtime branch April 17, 2024 21:05
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants