Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): bump react simple icons #749

Merged
merged 1 commit into from
Apr 11, 2024
Merged

chore(core): bump react simple icons #749

merged 1 commit into from
Apr 11, 2024

Conversation

deini
Copy link
Member

@deini deini commented Apr 11, 2024

What/Why?

@icons-pack/react-simple-icons released a new patch version addressing the typing issues with latest @types/react.

This change should fix the errors in #738

Testing

CI 👀

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 2:43pm
catalyst-testbed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 2:43pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Apr 11, 2024 2:43pm
catalyst-au ⬜️ Ignored (Inspect) Apr 11, 2024 2:43pm
catalyst-storybook ⬜️ Ignored (Inspect) Apr 11, 2024 2:43pm
catalyst-uk ⬜️ Ignored (Inspect) Apr 11, 2024 2:43pm

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: ae8a986

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-r9pny5z1t-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

@deini deini added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 5041719 Apr 11, 2024
15 checks passed
@deini deini deleted the deini/bump-rsi branch April 11, 2024 16:18
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants