feat(core): Support SSG when the cart is non-empty #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc34a01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
christensenep
force-pushed
the
cart-client-component
branch
2 times, most recently
from
f481d9e to
5e955cf
Compare
christensenep
commented
Apr 2, 2024
chanceaclark
reviewed
Apr 2, 2024
christensenep
force-pushed
the
cart-client-component
branch
from
5e955cf to
923334c
Compare
christensenep
force-pushed
the
cart-client-component
branch
from
923334c to
7b0f6e0
Compare
chanceaclark
reviewed
Apr 3, 2024
chanceaclark
reviewed
Apr 3, 2024
christensenep
force-pushed
the
cart-client-component
branch
from
7b0f6e0 to
ff4458b
Compare
|
Thanks to @bobbyshaw for the feedback in #647 that led us down the path to improve this |
christensenep
force-pushed
the
cart-client-component
branch
from
ff4458b to
505ba19
Compare
christensenep
force-pushed
the
cart-client-component
branch
from
505ba19 to
bc34a01
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-n9xl1u9c2-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
deini
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Move the cart badge icon (indicating the number of items in the cart) to a client component, allowing us to drop the requirement that the user must not have a cart yet in order to support static routes. Now, the static pages are generated with empty carts, and when the client
CartBadgecomponent is initially rendered, it fetches the cart quantity from a new API endpoint. Revalidation of data still works as it did previously.Testing
Tested locally and in a vercel preview build, verifying that the transition from empty cart -> populated cart works correctly, as well as subsequent additions to the cart.