refactore(core): checkout summary #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9055cbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
jorgemoya
force-pushed
the
refactor-shipping
branch
from
303ba35 to
be5a963
Compare
jorgemoya
force-pushed
the
refactor-shipping
branch
from
be5a963 to
c424490
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-r69l00mx4-bigcommerce-platform.vercel.app/ |
chanceaclark
approved these changes
Mar 28, 2024
deini
approved these changes
Mar 28, 2024
Comment on lines
16
to
17
| const checkout = await getCheckout(cartId); | ||
| const shippingCountries = await getShippingCountries(); |
jorgemoya
force-pushed
the
refactor-shipping
branch
from
7d6a8f6 to
9055cbb
Compare
This was referenced Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Refactor checkout summary to:
checkoutfield (including subtotal + grand total).How
checkoutfield in GQL (getCheckoutquery).checkoutwhen necessary._componentsin/cart(unfortunately git didn't match the moves).Kapture.2024-03-26.at.16.57.02.mp4
Testing
Locally.