feat(core): use focus-visible instead of focus #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b269035 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
christensenep
force-pushed
the
use-focus-visible
branch
from
2b3ec39 to
b8f58f2
Compare
matthewvolk
approved these changes
Mar 12, 2024
Impressive catch, had modified but not saved the file, thanks. |
christensenep
force-pushed
the
use-focus-visible
branch
from
b8f58f2 to
b269035
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-k2jyhpp45-bigcommerce-platform.vercel.app/ |
jorgemoya
approved these changes
Mar 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Use
focus-visibleinstead offocus, so that we retain our focus styles for accessibility purposes, but do not style elements when focused via actions like click or touch events.Testing
Ensured no focus styling is visible when using click or touch events, but remains when navigating via keyboard.