feat(core): reset password #638

bc-alexsaiannyi · 2024-03-12T08:53:53Z

What/Why?

This PR adds functionality to reset password for Customer and includes 2 steps:

reset password email,
change password

it's based on PR with mutations.

Testing

locally

vercel · 2024-03-12T08:54:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-latest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2024 8:21pm

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
catalyst	⬜️ Ignored (Inspect)		Mar 26, 2024 8:21pm
catalyst-1millionproducts-store	⬜️ Ignored (Inspect)	Visit Preview	Mar 26, 2024 8:21pm
catalyst-2000ms-api	⬜️ Ignored (Inspect)		Mar 26, 2024 8:21pm
catalyst-au	⬜️ Ignored (Inspect)	Visit Preview	Mar 26, 2024 8:21pm
catalyst-no-kv	⬜️ Ignored (Inspect)		Mar 26, 2024 8:21pm
catalyst-nodejs	⬜️ Ignored (Inspect)		Mar 26, 2024 8:21pm
catalyst-storybook	⬜️ Ignored (Inspect)	Visit Preview	Mar 26, 2024 8:21pm
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview	Mar 26, 2024 8:21pm

changeset-bot · 2024-03-13T16:27:12Z

🦋 Changeset detected

Latest commit: 1093c67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@bigcommerce/catalyst-core	Minor
@bigcommerce/components	Patch
@bigcommerce/docs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

matthewvolk · 2024-03-13T21:19:48Z

Needs changeset 🦋

BC-krasnoshapka · 2024-03-20T10:17:01Z

apps/core/app/[locale]/(default)/login/_components/reset-password-form.tsx

+    <Button
+      className="relative w-fit items-center px-8 py-2"
+      data-button
+      disabled={pending}
+      variant="primary"
+    >
+      <>
+        {pending && (
+          <>
+            <span className="absolute z-10 flex h-full w-full items-center justify-center bg-gray-400">
+              <Spinner aria-hidden="true" className="animate-spin" />
+            </span>
+            <span className="sr-only">{t('spinnerText')}</span>
+          </>
+        )}
+        <span aria-hidden={pending}>{t('submitText')}</span>
+      </>
+    </Button>


Just noticed the same component is used in #665 change password form.

Yeah. Actually, now we have around 6 forms with submit button which are different basically only with their texts. I was thinking about creating abstraction with text params that will return <SubmitButton> & reuse it across all forms💅 That why for now I decide to keep it separately.

jorgemoya

Looks good but we do need to know if we want to have a different path to reset passwords other than reusing /login 🤔

bc-alexsaiannyi · 2024-03-26T09:03:14Z

Looks good but we do need to know if we want to have a different path to reset passwords other than reusing /login 🤔

Yeah, it's a good point, Jorge. Now, when RequestResetPasswordInput can deal with path, I've added it to submit function also. I believe it should be done explicitly since if we skip this argument on calling submit fn we get next result - https://your-store/login.php?c=XX&t=XXX. In this way it inherits || reproduces current stencil behaviour, if we miss completely path in arguments, we get smth like https://your-store?c=XX&t=XXX.
So to receive https://your-store?login?c=XX&t=XXX I'm providing it as an argument:

submitResetPasswordForm({ formData, reCaptchaToken, path: '/login' });

yurytut1993 · 2024-03-26T15:34:10Z

apps/core/app/[locale]/(default)/login/_actions/submit-reset-password-form.ts

+    }
+
+    return {
+      status: 'failed',


should we change status to error here?

Hmm, I was sure that I did change it. Thanks for catching this.

yurytut1993

👌

github-actions · 2024-03-26T20:23:09Z

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category	Score
🟢 Performance	99
🟢 Accessibility	100
🟠 Best practices	78
🟢 SEO	92

Lighthouse ran against https://catalyst-latest-llo8m97m6-bigcommerce-platform.vercel.app/

bc-alexsaiannyi requested a review from a team as a code owner March 12, 2024 08:53

bc-alexsaiannyi added the draft Ready for initial review label Mar 12, 2024

bc-alexsaiannyi force-pushed the reset-password branch from ab9842f to 4b8b462 Compare March 13, 2024 16:27

vercel bot had a problem deploying to Preview – catalyst-latest March 13, 2024 16:28 Failure

bc-alexsaiannyi force-pushed the reset-password branch from 4b8b462 to 12f657a Compare March 14, 2024 09:23

vercel bot deployed to Preview – catalyst-latest March 14, 2024 09:27 View deployment

bc-alexsaiannyi removed the draft Ready for initial review label Mar 14, 2024

bc-alexsaiannyi force-pushed the reset-password branch from 12f657a to c15a4de Compare March 14, 2024 14:14

vercel bot deployed to Preview – catalyst-latest March 14, 2024 14:18 View deployment

bc-alexsaiannyi force-pushed the reset-password branch from c15a4de to bc839ba Compare March 14, 2024 14:51

vercel bot deployed to Preview – catalyst-latest March 14, 2024 14:52 View deployment

bc-alexsaiannyi force-pushed the reset-password branch from bc839ba to f9135e6 Compare March 18, 2024 13:58

vercel bot deployed to Preview – catalyst-latest March 18, 2024 14:01 View deployment

bc-alexsaiannyi force-pushed the reset-password branch 2 times, most recently from e9ed37d to 0517143 Compare March 18, 2024 14:16

vercel bot deployed to Preview – catalyst-latest March 18, 2024 14:21 View deployment

bc-alexsaiannyi force-pushed the reset-password branch from 0517143 to 1445935 Compare March 19, 2024 08:28

vercel bot deployed to Preview – catalyst-latest March 19, 2024 08:32 View deployment

BC-krasnoshapka reviewed Mar 20, 2024

View reviewed changes

jorgemoya approved these changes Mar 25, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the reset-password branch from 1445935 to 3310ae0 Compare March 26, 2024 13:16

vercel bot deployed to Preview – catalyst-latest March 26, 2024 13:21 View deployment

bc-alexsaiannyi force-pushed the reset-password branch from 3310ae0 to 6d5ca09 Compare March 26, 2024 13:23

vercel bot deployed to Preview – catalyst-latest March 26, 2024 13:27 View deployment

yurytut1993 reviewed Mar 26, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the reset-password branch from 6d5ca09 to b7eb25b Compare March 26, 2024 15:37

vercel bot deployed to Preview – catalyst-latest March 26, 2024 15:41 View deployment

yurytut1993 approved these changes Mar 26, 2024

View reviewed changes

bc-alexsaiannyi force-pushed the reset-password branch from b7eb25b to baa74d5 Compare March 26, 2024 20:03

vercel bot deployed to Preview – catalyst-latest March 26, 2024 20:07 View deployment

feat(core): add components for reset password

1093c67

bc-alexsaiannyi force-pushed the reset-password branch from baa74d5 to 1093c67 Compare March 26, 2024 20:18

vercel bot deployed to Preview – catalyst-latest March 26, 2024 20:21 View deployment

bc-alexsaiannyi added this pull request to the merge queue Mar 26, 2024

Merged via the queue into main with commit a1f7970 Mar 26, 2024
11 checks passed

bc-alexsaiannyi deleted the reset-password branch March 26, 2024 20:25

This was referenced Mar 26, 2024

Version Packages #707

Merged

Version Packages ah100101/catalyst#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): reset password #638

feat(core): reset password #638

bc-alexsaiannyi commented Mar 12, 2024

vercel bot commented Mar 12, 2024 •

edited

Loading

changeset-bot bot commented Mar 13, 2024 •

edited

Loading

matthewvolk commented Mar 13, 2024

BC-krasnoshapka Mar 20, 2024

bc-alexsaiannyi Mar 20, 2024 •

edited

Loading

jorgemoya left a comment

bc-alexsaiannyi commented Mar 26, 2024

yurytut1993 Mar 26, 2024

bc-alexsaiannyi Mar 26, 2024

yurytut1993 left a comment

github-actions bot commented Mar 26, 2024

feat(core): reset password #638

feat(core): reset password #638

Conversation

bc-alexsaiannyi commented Mar 12, 2024

What/Why?

Testing

vercel bot commented Mar 12, 2024 • edited Loading

changeset-bot bot commented Mar 13, 2024 • edited Loading

🦋 Changeset detected

matthewvolk commented Mar 13, 2024

BC-krasnoshapka Mar 20, 2024

Choose a reason for hiding this comment

bc-alexsaiannyi Mar 20, 2024 • edited Loading

Choose a reason for hiding this comment

jorgemoya left a comment

Choose a reason for hiding this comment

bc-alexsaiannyi commented Mar 26, 2024

yurytut1993 Mar 26, 2024

Choose a reason for hiding this comment

bc-alexsaiannyi Mar 26, 2024

Choose a reason for hiding this comment

yurytut1993 left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 26, 2024

⚡️🏠 Lighthouse report

vercel bot commented Mar 12, 2024 •

edited

Loading

changeset-bot bot commented Mar 13, 2024 •

edited

Loading

bc-alexsaiannyi Mar 20, 2024 •

edited

Loading