Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): rename query/mutations to standard names #1928

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Noticed some queries/mutations were not using the standardized naming. I feel it may seem redundant in many cases, but we either we have all named the same or we remove the trailing Query/Mutation.

Testing

Nothing changes.

@jorgemoya jorgemoya requested a review from a team as a code owner January 23, 2025 21:53
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 5a1ca6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 9:54pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 23, 2025 9:54pm
catalyst-au ⬜️ Ignored (Inspect) Jan 23, 2025 9:54pm
catalyst-soul ⬜️ Ignored (Inspect) Jan 23, 2025 9:54pm
catalyst-uk ⬜️ Ignored (Inspect) Jan 23, 2025 9:54pm

@jorgemoya jorgemoya enabled auto-merge January 23, 2025 21:54
@jorgemoya jorgemoya added this pull request to the merge queue Jan 23, 2025
Merged via the queue into canary with commit 157ea54 Jan 23, 2025
10 checks passed
@jorgemoya jorgemoya deleted the gql-query-names branch January 23, 2025 21:57
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-7jf791gbz-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants