Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename footer.tsx to index.tsx #1926

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: rename footer.tsx to index.tsx #1926

merged 1 commit into from
Jan 22, 2025

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Simple oversight since we use index for the rest of the component files.

Testing

No change.

@jorgemoya jorgemoya requested a review from a team as a code owner January 22, 2025 19:09
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 7:11pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 22, 2025 7:11pm
catalyst-au ⬜️ Ignored (Inspect) Jan 22, 2025 7:11pm
catalyst-soul ⬜️ Ignored (Inspect) Jan 22, 2025 7:11pm
catalyst-uk ⬜️ Ignored (Inspect) Jan 22, 2025 7:11pm

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: f9ad35f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jorgemoya jorgemoya added this pull request to the merge queue Jan 22, 2025
Merged via the queue into canary with commit c30a9d9 Jan 22, 2025
10 checks passed
@jorgemoya jorgemoya deleted the fix-footer-index branch January 22, 2025 20:15
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-pknx0r150-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 82
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants