Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested web pages #1923

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Add support for nested web pages #1923

merged 1 commit into from
Jan 23, 2025

Conversation

jordanarldt
Copy link
Contributor

@jordanarldt jordanarldt commented Jan 21, 2025 •
edited
Loading

Depends on: makeswift/vibes#471

What/Why?

  • Add support for nested web page children
  • Refactor AccountLayout and instead use StickySidebarLayout with SidebarMenu component
  • Refactor web page routing structure to /webpages/{pageId}/normal or /webpages/{pageId}/contact. This allows us to have a web page layout file that can fetch the child links.
  • Update footer to only add links for top-level web pages
  • Add breadcrumb truncation capability on deeply nested pages

Testing

Screen.Recording.2025-01-21.at.2.15.44.PM.mov

@jordanarldt jordanarldt requested a review from a team as a code owner January 21, 2025 20:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 854a25f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:53pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 23, 2025 5:53pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:53pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:53pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:53pm

@jordanarldt jordanarldt force-pushed the ja/add-web-page-children branch from a24fe2b to c18facd Compare January 22, 2025 16:04
@jordanarldt jordanarldt force-pushed the ja/add-web-page-children branch from c18facd to b815221 Compare January 22, 2025 16:56
jorgemoya
jorgemoya reviewed Jan 22, 2025
View reviewed changes
core/app/[locale]/(default)/webpages/[id]/contact/_actions/submit-contact-form.ts Outdated Show resolved Hide resolved
core/components/footer/fragment.ts
@@ -26,7 +26,7 @@ export const FooterFragment = graphql(`
}
}
content {
pages(filters: { isVisibleInNavigation: true }) {
pages(filters: { parentEntityIds: [0] }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change? Only fetch the root pages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgemoya Yes, exactly. For the footer, we only want the top-level pages, and also we want to include web pages that don't have isVisibleInNavigation: true - this value is only pertinent to what is displayed in the nav bar, not the footer.

@jordanarldt jordanarldt force-pushed the ja/add-web-page-children branch from b815221 to eef4326 Compare January 22, 2025 19:21
@jordanarldt jordanarldt force-pushed the ja/add-web-page-children branch from eef4326 to 44a2390 Compare January 23, 2025 17:14
@jordanarldt jordanarldt force-pushed the ja/add-web-page-children branch from 44a2390 to 854a25f Compare January 23, 2025 17:52
@jordanarldt jordanarldt added this pull request to the merge queue Jan 23, 2025
Merged via the queue into canary with commit 62b891c Jan 23, 2025
9 checks passed
@jordanarldt jordanarldt deleted the ja/add-web-page-children branch January 23, 2025 18:53
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-cvm1afwg1-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanarldt @jorgemoya