refactor(cli)!: remove auto generation of gql types on project creation #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a40d062 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
matthewvolk
force-pushed
the
cli/remove-generate
branch
from
eec446c to
b1e2d00
Compare
matthewvolk
force-pushed
the
cli/remove-generate
branch
from
b1e2d00 to
483f47b
Compare
matthewvolk
force-pushed
the
cli/remove-generate
branch
from
483f47b to
aaf3e0f
Compare
matthewvolk
changed the title
deini
approved these changes
Oct 10, 2024
matthewvolk
force-pushed
the
cli/remove-generate
branch
from
aaf3e0f to
11a6371
Compare
matthewvolk
force-pushed
the
cli/remove-generate
branch
from
11a6371 to
a40d062
Compare
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-2wll2ilru-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Important
This PR stacks on #1441
Remove automatic generation of GraphQL type definitions on project creation. There is no root-level
generateTurbo task, which means the environment variables aren't being picked up correctly.We could refactor
writeEnvto write two env files, one in root and one incore/but I'm not confident that's the right solution.Testing
Locally