Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli)!: make cloneCatalyst clone bigcommerce/catalyst #1438

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

matthewvolk
Copy link
Contributor

What/Why?

💡 This PR is part of the CLI refactor changes described in #1430

Important

This PR stacks on #1437

Refactor cloneCatalyst so that it simply clones the bigcommerce/catalyst repo, configures remotes, and checks out an optional ref

Testing

Locally

@matthewvolk matthewvolk requested a review from a team as a code owner October 9, 2024 22:46
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 35fe9f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 9:28pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 10, 2024 9:28pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:28pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:28pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:28pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:28pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:28pm

@bookernath
Copy link
Contributor

Seems like we should accept an arg to specify another repo while we're in here... seems like a simple addition and this is the right time to make it

@matthewvolk matthewvolk changed the title refactor(cli): make cloneCatalyst clone bigcommerce/catalyst refactor(cli)!: make cloneCatalyst clone bigcommerce/catalyst Oct 10, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-gwynife6x-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@matthewvolk matthewvolk enabled auto-merge October 10, 2024 21:14
@matthewvolk matthewvolk added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit d12c0d2 Oct 10, 2024
3 of 10 checks passed
@matthewvolk matthewvolk deleted the cli/clone-catalyst branch October 10, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants