Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass ip information to request on non-cacheable requests #1384

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Passes the customer IP on non-cacheable requests so we can enforce things like rate limiting.

Testing

x-real-ip is the Vercel Server IP, while x-forwarded-for is my personal IP
Screenshot 2024-09-18 at 15 03 50

@chanceaclark chanceaclark requested a review from a team as a code owner September 18, 2024 19:06
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 495d3aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@bigcommerce/catalyst-core Minor
@bigcommerce/catalyst-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 7:06pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 18, 2024 7:06pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Sep 18, 2024 7:06pm
catalyst-au ⬜️ Ignored (Inspect) Sep 18, 2024 7:06pm
catalyst-test-store ⬜️ Ignored (Inspect) Sep 18, 2024 7:06pm
catalyst-uk ⬜️ Ignored (Inspect) Sep 18, 2024 7:06pm
catalyst-unstable ⬜️ Ignored (Inspect) Sep 18, 2024 7:06pm

@chanceaclark chanceaclark added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 17692ca Sep 18, 2024
14 checks passed
@chanceaclark chanceaclark deleted the chanceaclark/proxy branch September 18, 2024 19:41
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-n22wefil9-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 77
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants