fix: quick order add product to cart without sku

https://bigc-b2b.atlassian.net/browse/BUN-1220
bigcommerce · Jun 28, 2023 · a5fc150 · a5fc150
1 parent 3faca98
commit a5fc150
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 3 deletions.
diff --git a/apps/storefront/src/hooks/dom/utils.ts b/apps/storefront/src/hooks/dom/utils.ts
@@ -275,11 +275,20 @@ const addProductsFromCartToQuote = (setOpenPage: DispatchProps) => {
 
       const cartProductsList = getCartProducts(lineItems)
 
+      const noSkuProducts = cartProductsList.filter(({ sku }) => !sku)
+
+      if (noSkuProducts.length > 0) {
+        globalSnackbar.error('Can not add products without SKU.', {
+          isClose: true,
+        })
+      }
+
       if (cartProductsList.length === 0) {
         globalSnackbar.error('No products being added.', {
           isClose: true,
         })
       }
+      if (noSkuProducts.length === cartProductsList.length) return
 
       const isSuccess = await addProductsToDraftQuote(cartProductsList)
       if (isSuccess) {

diff --git a/apps/storefront/src/pages/quickorder/components/QuickOrderFooter.tsx b/apps/storefront/src/pages/quickorder/components/QuickOrderFooter.tsx
@@ -156,7 +156,10 @@ function QuickOrderFooter(props: QuickOrderFooterProps) {
       const { node } = item
 
       inventoryInfos.forEach((inventory: CustomFieldItems) => {
-        if (node.variantSku === inventory.variantSku) {
+        if (
+          node.variantSku === inventory.variantSku &&
+          +node.variantId === +inventory.variantId
+        ) {
           const { optionList, quantity } = node
 
           const options = optionList.map((option: CustomFieldItems) => ({
@@ -274,6 +277,20 @@ function QuickOrderFooter(props: QuickOrderFooterProps) {
         }
       )
 
+      const noSkuProducts = checkedArr.filter((checkedItem: ListItemProps) => {
+        const {
+          node: { variantSku },
+        } = checkedItem
+
+        return !variantSku
+      })
+      if (noSkuProducts.length > 0) {
+        snackbar.error('Can not add products without SKU.', {
+          isClose: true,
+        })
+      }
+      if (noSkuProducts.length === checkedArr.length) return
+
       const productIds: number[] = []
       productsWithSku.forEach((product: ListItemProps) => {
         const { node } = product

diff --git a/apps/storefront/src/pages/quote/components/AddToQuote.tsx b/apps/storefront/src/pages/quote/components/AddToQuote.tsx
@@ -97,6 +97,15 @@ export default function AddToQuote(props: AddToListProps) {
   const addToList = async (products: CustomFieldItems[]) => {
     const newProducts = getNewQuoteProduct(products)
 
+    const noSkuProducts = products.filter(({ sku }) => !sku)
+    if (noSkuProducts.length > 0) {
+      snackbar.error('Can not add products without SKU.', {
+        isClose: true,
+      })
+    }
+
+    if (noSkuProducts.length === products.length) return []
+
     addToQuote(newProducts)
 
     snackbar.success('Product were added to your quote.', {

diff --git a/apps/storefront/src/utils/graphqlDataConvert.ts b/apps/storefront/src/utils/graphqlDataConvert.ts
@@ -46,8 +46,12 @@ export const convertObjectToGraphql = (data: CustomFieldItems) => {
 
 export const convertArrayToGraphql = (data: CustomFieldItems) => {
   let str = '['
-  data.forEach((list: any) => {
-    str += convertObjectToGraphql(list)
+  data.forEach((list: CustomFieldItems, index: number) => {
+    if (index === data.length - 1) {
+      str += convertObjectToGraphql(list)
+    } else {
+      str += `${convertObjectToGraphql(list)},`
+    }
   })
   str += ']'