Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev Script in package.json to Use cross-env #588

Merged

Conversation

Champetaman
Copy link
Contributor

Summary
This PR updates the dev script in the /webapp/package.json file to ensure cross-platform compatibility for setting environment variables.

Changes Made
Old Script: "dev": "PORT=4000 craco start"

New Script: "dev": "cross-env PORT=4000 craco start"

Reason for Change
The previous method of setting the PORT variable was only compatible with UNIX-like systems. By using cross-env, this change ensures the development server can be started on both Windows and macOS/Linux systems without any issues.

Copy link
Contributor

@abouolia abouolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for your contribution.

@abouolia abouolia merged commit 01b7c86 into bigcapitalhq:develop Aug 12, 2024
@Champetaman Champetaman deleted the fix-dev-variable-setting-error branch August 13, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants