-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spectrumAI #70
add spectrumAI #70
Conversation
Two works were possible using validate_peptides, one to calculate the position of the variant amino acids on the variant peptide and the other to validate the variant peptide using spectrumAI. |
This reverts commit 364e1e0.
Thanks for the great work. I agree with @ypriverol it would be better to have one command for both processes. To avoid re-calculating the variant position we can have a condition to skip the process if the position column exists in the Also, regarding the |
Thank you for your affirmation.At present, they are under one command, but they still belong to two separate processes. Do you mean we can merge into one process? |
No, @DongdongdongW now is fine with only one command. The only pending task is to support mzTab. |
got it |
add mztab class-fdr and modified the code that validates peptides
Regarding replacing blast to identify the variant position, we discussed the following with @ypriverol:
|
Use our own method to compare peptides and sequences? @husensofteng |
yes, if we can have an efficient implementation, |
pypgatk/tests/pypgatk_tests.py
Outdated
def test_get_subpos(self): | ||
runner = CliRunner() | ||
result = runner.invoke(cli, | ||
['get_subpos', '--input_psm_table', 'testdata/MFA380.tsv', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MFA380.tsv @DongdongdongW where is this file?
No description provided.