-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Transition to src/ layout #1099
Conversation
Update versioneer location while we're at it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 89.78% 89.67% -0.11%
==========================================
Files 64 65 +1
Lines 7154 7119 -35
Branches 835 836 +1
==========================================
- Hits 6423 6384 -39
- Misses 534 537 +3
- Partials 197 198 +1 ☔ View full report in Codecov by Sentry. |
A review would be appreciated if someone has the time, but I'm comfortable with our test coverage and the scope of these changes to merge without review. Will merge tomorrow unless stopped. |
Ah, it's not a UT holiday. @adelavega any interest in a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just from looking at the commits everything looks fine to me.
Did you try installing it locally just to do a sanity check? Otherwise LGTM.
Yeah, basic stuff works, and we've got like >90% test coverage so I think we're pretty safe. |
great! thanks! |
This PR moves
bids
intosrc/bids
and the majority of the data inbids/tests/data
intotests/data
. This ensures the data is present in sdists so that full tests can be run, while omitted from wheels and installed modules.Probably easiest to review commit-by-commit. The first commit is nothing but the move, so it's easiest to ignore that.
Closes #1090.