Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Transition to src/ layout #1099

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Nov 11, 2024

This PR moves bids into src/bids and the majority of the data in bids/tests/data into tests/data. This ensures the data is present in sdists so that full tests can be run, while omitted from wheels and installed modules.

Probably easiest to review commit-by-commit. The first commit is nothing but the move, so it's easiest to ignore that.

Closes #1090.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 94.63087% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (88c32ef) to head (1e6449e).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/bids/layout/tests/conftest.py 91.42% 6 Missing ⚠️
src/bids/conftest.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   89.78%   89.67%   -0.11%     
==========================================
  Files          64       65       +1     
  Lines        7154     7119      -35     
  Branches      835      836       +1     
==========================================
- Hits         6423     6384      -39     
- Misses        534      537       +3     
- Partials      197      198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

A review would be appreciated if someone has the time, but I'm comfortable with our test coverage and the scope of these changes to merge without review.

Will merge tomorrow unless stopped.

@effigies
Copy link
Collaborator Author

Ah, it's not a UT holiday. @adelavega any interest in a quick look?

@adelavega adelavega self-requested a review November 11, 2024 16:23
Copy link
Collaborator

@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from looking at the commits everything looks fine to me.

Did you try installing it locally just to do a sanity check? Otherwise LGTM.

@effigies
Copy link
Collaborator Author

Yeah, basic stuff works, and we've got like >90% test coverage so I think we're pretty safe.

@effigies effigies merged commit 2934208 into bids-standard:master Nov 11, 2024
20 checks passed
@effigies effigies deleted the src-layout branch November 11, 2024 16:30
@bpinsard
Copy link
Contributor

great! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PERF] tests data uses 8k inodes
3 participants