[MAINT] transfer test to bids validator #1081
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
==========================================
- Coverage 89.81% 89.72% -0.09%
==========================================
Files 63 63
Lines 7174 7123 -51
Branches 1373 1363 -10
==========================================
- Hits 6443 6391 -52
- Misses 532 533 +1
Partials 199 199 ☔ View full report in Codecov by Sentry. |
bids/layout/tests/test_validation.py
Outdated
| def test_layout_with_validation(): | ||
| data_dir = join(get_test_data_path(), '7t_trt') | ||
| layout1 = BIDSLayout(data_dir, validate=True) | ||
| layout2 = BIDSLayout(data_dir, validate=False) | ||
| assert len(layout1.files) < len(layout2.files) | ||
| # Not a valid BIDS file | ||
| badfile = join(data_dir, 'test.bval') | ||
| assert badfile not in layout1.files | ||
| assert badfile in layout2.files |
There was a problem hiding this comment.
Unless this test exists elsewhere, it's worth keeping.
There was a problem hiding this comment.
ah yes true
good catch
The bad values might be worth it, just as |
OK I will try to transfer those then. |
|
will merge #1080 before this one |
companion PR to bids-standard/python-validator#8
there are more than 600 lines of test that are commented: should I bother transferring them to the other repo too?