Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer BIDSValidation error message #1023

Merged

Conversation

pierre-nedelec
Copy link
Contributor

Print path to file that raises the error message
Fixes #1022

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f0d198d) 83.46% compared to head (5dd012f) 83.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files          38       38           
  Lines        4307     4307           
  Branches     1097     1097           
=======================================
  Hits         3595     3595           
  Misses        514      514           
  Partials      198      198           
Files Changed Coverage Δ
bids/layout/validation.py 85.91% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 3100601 into bids-standard:master Sep 6, 2023
@pierre-nedelec pierre-nedelec deleted the pierre-nedelec/issue1022 branch September 7, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIDSValidation error message doesn't provide path of erroneous dataset_description.json
2 participants