Include indexer in add_derivatives call #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instantiation of derivative dataset via kwargs.
|
WIP - haven't tested this yet |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 83.42% 83.42% -0.01%
==========================================
Files 38 38
Lines 4290 4289 -1
Branches 1100 1099 -1
==========================================
- Hits 3579 3578 -1
Misses 515 515
Partials 196 196
☔ View full report in Codecov by Sentry. |
adelavega
approved these changes
Jul 7, 2023
|
@effigies since you made an edit I will wait on you to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fix which passes the indexer object into add_derivatives along with indexer kwargs.
Previously, index options could only be included in derivative datasets with index kwargs, which are deprecated.
This includes the indexer object in derivative BIDSLayout instantiation.
closes #970