Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate RF of acknowledgement to provide listing for other funders #279

Merged
merged 8 commits into from
Jun 16, 2023

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Feb 9, 2023

Since many other projects, even if not directly funded to develop BIDS, contributed to either parts of BIDS, or specific BEPS.

Also here I added reference to individual committers document in the specification.

TODO(s) -- I think primarily will be done later. Let's get it out in some form to start

  • decide on sorting. kinda decided: keep as currently is, might resrt later
  • decide on how much information to provide, may be to mention specific contributors?
  • add more right in this PR
  • make a call for ppl to contribute

Since many other projects, even if not directly funded to develop BIDS,
contributed to either parts of BIDS, or specific BEPS.

Also here I added reference to individual committers document in the specification.
@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for astounding-beignet-8ca2d6 ready!

Name Link
🔨 Latest commit a4aa0fc
🔍 Latest deploy log https://app.netlify.com/sites/astounding-beignet-8ca2d6/deploys/648281f9ff3290000872fbeb
😎 Deploy Preview https://deploy-preview-279--astounding-beignet-8ca2d6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bendhouseart
Copy link
Contributor

bendhouseart commented May 17, 2023

@yarikoptic This needs to be better formatted (and completed), but adding information in here in the meantime.

Funding Source | Target
----- | -----
[NIMH MH117179](https://reporter.nih.gov/project-details/10145071) | OpenNeuro archive contributed various enhancements and fixes
[NIMH 1ZIAMH002977-01](https://reporter.nih.gov/project-details/10489085) |  OpenNeuroPET project contributed various enhancements and fixes 
[NIMH 5R01MH126699-02](https://reporter.nih.gov/project-details/10460628) | Brain Connectivity BEP
[NIMH MH109682](https://reporter.nih.gov/project-details/9982125) | NeuroScout
[Novo Nordisk NNF20OC0063277]() | 

Tagging @poldrack @francopestilli for further comment on Target above and/or additional sources.

And closing my redundant PR #292

@yarikoptic
Copy link
Contributor Author

@bendhouseart could you add recommended changes as the suggestion or just push to my branch -- I invited you to collaborate onmy fork https://github.com/yarikoptic/BIDS/

@bendhouseart
Copy link
Contributor

bendhouseart commented May 17, 2023

@bendhouseart could you add recommended changes as the suggestion or just push to my branch -- I invited you to collaborate onmy fork https://github.com/yarikoptic/BIDS/

Done, will push other changes to your branch in the future.

@Remi-Gau
Copy link
Contributor

Note do we want to keep this in markdown or dump that in yaml and use some jekyll to create the table for us.

Do not have to be decided here and now: I can jekyll the 💩 out of this later if that's easier.

@yarikoptic
Copy link
Contributor Author

Having it machine readable might be handy indeed. But I think we better first collect enough of "use-cases" to see what could be the schema to facilitate some extra features besides listing the funders here.

@yarikoptic
Copy link
Contributor Author

I am confused about errors I see

seems to be all about broken URLs to twitter which are unrelated to this PR
2023-05-18T15:33:15.9774070Z [✖] https://twitter.com/bidsstandard → Status: 0 Error: Exceeded maxRedirects. Probably stuck in a redirect loop https://twitter.com/bidsstandard
2023-05-18T15:33:15.9775246Z     at Redirect.onResponse (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/lib/redirect.js:98:27)
2023-05-18T15:33:15.9776215Z     at Request.onRequestResponse (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/request.js:986:22)
2023-05-18T15:33:15.9780476Z     at ClientRequest.emit (node:events:513:28)
2023-05-18T15:33:15.9780934Z     at HTTPParser.parserOnIncomingClient (node:_http_client:701:27)
2023-05-18T15:33:15.9781415Z     at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
2023-05-18T15:33:15.9781852Z     at TLSSocket.socketOnData (node:_http_client:542:22)
2023-05-18T15:33:15.9782215Z     at TLSSocket.emit (node:events:513:28)
2023-05-18T15:33:15.9782889Z     at addChunk (node:internal/streams/readable:324:12)
2023-05-18T15:33:15.9783283Z     at readableAddChunk (node:internal/streams/readable:297:9)
2023-05-18T15:33:15.9783671Z     at Readable.push (node:internal/streams/readable:234:10)
2023-05-18T15:33:15.9785116Z [✖] https://twitter.com/BIDSstandard → Status: 0 Error: Exceeded maxRedirects. Probably stuck in a redirect loop https://twitter.com/BIDSstandard
2023-05-18T15:33:15.9785974Z     at Redirect.onResponse (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/lib/redirect.js:98:27)
2023-05-18T15:33:15.9786735Z     at Request.onRequestResponse (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/request.js:986:22)
2023-05-18T15:33:15.9787197Z     at ClientRequest.emit (node:events:513:28)
2023-05-18T15:33:15.9787608Z     at HTTPParser.parserOnIncomingClient (node:_http_client:701:27)
2023-05-18T15:33:15.9788099Z     at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
2023-05-18T15:33:15.9788763Z     at TLSSocket.socketOnData (node:_http_client:542:22)
2023-05-18T15:33:15.9789118Z     at TLSSocket.emit (node:events:513:28)
2023-05-18T15:33:15.9789466Z     at addChunk (node:internal/streams/readable:324:12)
2023-05-18T15:33:15.9793083Z     at readableAddChunk (node:internal/streams/readable:297:9)
2023-05-18T15:33:15.9794703Z     at Readable.push (node:internal/streams/readable:234:10)
2023-05-18T15:33:15.9795111Z 
2023-05-18T15:33:15.9795221Z 69 links checked.
2023-05-18T15:33:15.9795378Z 
2023-05-18T15:33:15.9799239Z ERROR: 2 dead links found!
2023-05-18T15:33:15.9835490Z [✖] https://twitter.com/bidsstandard → Status: 0
2023-05-18T15:33:15.9836107Z [✖] https://twitter.com/BIDSstandard → Status: 0
2023-05-18T15:33:15.9836703Z 

and the same workflow fails in another PR #293 so must be a common thing. Edited here file seems to be ok?

❯ grep -2 ackno markdown-link-check/*
markdown-link-check/4_Run gaurav-nelsongithub-action-markdown-link-check@v1.txt-2023-05-18T15:33:15.9770619Z 18 links checked.
markdown-link-check/4_Run gaurav-nelsongithub-action-markdown-link-check@v1.txt-2023-05-18T15:33:15.9770770Z 
markdown-link-check/4_Run gaurav-nelsongithub-action-markdown-link-check@v1.txt:2023-05-18T15:33:15.9770901Z FILE: _pages/acknowledgements.md
markdown-link-check/4_Run gaurav-nelsongithub-action-markdown-link-check@v1.txt-2023-05-18T15:33:15.9771380Z 
markdown-link-check/4_Run gaurav-nelsongithub-action-markdown-link-check@v1.txt-2023-05-18T15:33:15.9771486Z 13 links checked.

@Remi-Gau
Copy link
Contributor

Having it machine readable might be handy indeed. But I think we better first collect enough of "use-cases" to see what could be the schema to facilitate some extra features besides listing the funders here.

makes sense: let's revisit later (at least once the PR is merged)

@Remi-Gau
Copy link
Contributor

I am confused about errors I see
seems to be all about broken URLs to twitter which are unrelated to this PR

and the same workflow fails in another PR #293 so must be a common thing. Edited here file seems to be ok?

It seems like a "recent" thing. Not sure what's happening.

https://github.com/bids-standard/bids-website/actions/workflows/check_md_links.yml

maybe worth adding an ignore pattern in a mlc_config file

https://github.com/bids-standard/bids-matlab/blob/master/.github/workflows/mlc_config.json

yarikoptic and others added 2 commits May 19, 2023 15:53
Co-authored-by: Anthony Galassi <28850131+bendhouseart@users.noreply.github.com>
Funding Source | Target
----- | -----
[International Neuroinformatics Coordinating Facility](https://www.incf.org/){:target="_blank"} | [Neuroimaging Data Sharing Task Force](https://web.archive.org/web/20170813183704/http://wiki.incf.org/mediawiki/index.php/Neuroimaging_Task_Force){:target="_blank"} collated initial group of people to push pilot BIDS development and promotion
Laura and John Arnold Foundation |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Laura and John Arnold Foundation |
Laura and John Arnold Foundation | Initial support for BIDS development

would this be right short description @poldrack ?

_pages/acknowledgments.md Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Contributor Author

Re sorting: I think it would make sense to leave INCF + Laura and John Arnold Foundation on the top and then sort the rest alphabetically... or just sort all alphabetically. "More correct" sorting would have been to add leading Dates column and sort by dates of the funding (which would also place INCF and LaJAF first) but that might be a bit too much to dig? (although I kinda like that idea, might be worth it)

@bendhouseart
Copy link
Contributor

Re sorting: I think it would make sense to leave INCF + Laura and John Arnold Foundation on the top and then sort the rest alphabetically... or just sort all alphabetically. "More correct" sorting would have been to add leading Dates column and sort by dates of the funding (which would also place INCF and LaJAF first) but that might be a bit too much to dig? (although I kinda like that idea, might be worth it)

Up to you really; I'd say to merge it once you've got confirmations down just to close out this PR. On the other hand, it's been open this long ;)

@yarikoptic
Copy link
Contributor Author

ok, let's give @poldrack a day ;)

@yarikoptic
Copy link
Contributor Author

ok, I'd say also merge it all up and fix if needed later. Anyone with super-powers to click the button? ;) Here is how it looks in the preview:

image

instead of current

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants