Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Enforce consistent line endings via .gitattributes #861

Merged
merged 1 commit into from
Aug 24, 2021
Merged

[INFRA] Enforce consistent line endings via .gitattributes #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
* text=auto
*.png -text
*.jpg -text
Comment on lines +2 to +3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub guide has the following for these lines:


# Denote all files that are truly binary and should not be modified.
*.png binary
*.jpg binary

Is -text equivalent? I think I find the GitHub way (together with the comment) more straight forward.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess "not text" is the same as "binary". I just copied over from the source - the gitattributes documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually binary is equivalent to -text -diff. Since this patch is about line endings, I'd rather stick with the documentation.