Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Find npm requirements file in Circle #336

Merged
merged 2 commits into from
Sep 24, 2019
Merged

[INFRA] Find npm requirements file in Circle #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ea6cd
Merge pull request #31 from bids-standard/master
franklin-feingold Sep 19, 2019
f51f4e3
point to the correct dir
franklin-feingold Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
name: get remark styles
command: |
cd ~
cat ~/build/npm-requirements.txt | xargs npm install
cat ~/project/npm-requirements.txt | xargs npm install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like there will be anything in ~/project? This doesn't make much sense to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked running the ssh on 1326 and there is a project folder. This folder is created at checkout

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~/project is the default CircleCI working directory, search for it (ctrl+f) on this page: https://circleci.com/docs/2.0/configuration-reference/

if you tested this and it works, this seems fine to me

- run: # remark the auto generated changes.md
name: remark on autogenerated CHANGES.md
command: |
Expand Down