-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Cleanup #29
[MISC] Cleanup #29
Conversation
chrisgorgo
commented
Oct 3, 2018
- adding sections that were left out from [MISC] split intro, commons, mr, and meg into directory from specification.md #28
- harmonizing how headers are handled
- removing header status from Examples
- removing the redundant big file
@@ -1,97 +1,9 @@ | |||
Magnetic Resonance Imaging data | |||
------------------------------- | |||
# Magnetic Resonance Imaging data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also applies to the MEG section below. Since this is listed as a subheading (h2) under the Modality Specific Files heading (existed only at the folder level right now), should this be marked as an h1 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool. that works. resolved
@@ -1,5 +1,4 @@ | |||
Appendix I: Contributors | |||
------------------------ | |||
# Appendix I: Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question about the nested folder structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved above
@@ -1,5 +1,4 @@ | |||
Appendix VI: MEG file formats | |||
------------------------------ | |||
# Appendix VI: MEG file formats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently there are two spaces between Appendix
and VI
lgtm, just one nitpick of space here #29 (comment). after you rebase and you include the updated license info from #31, feel free to merge |
thanks @chrisfilo! |