[ENH] adding release guidelines #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested changes
Jul 11, 2019
There was a problem hiding this comment.
Thanks @franklin-feingold! I made several wording changes. Perhaps you can commit them as a batch to avoid lots of commits.
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
emdupre
reviewed
Jul 15, 2019
There was a problem hiding this comment.
Thanks again, @franklin-feingold ✨ A few small suggestions / clarifications below 👇
effigies
reviewed
Jul 15, 2019
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
sappelhoff
reviewed
Jul 16, 2019
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
sappelhoff
previously approved these changes
Jul 18, 2019
|
Oh, sure. Sorry, let me look... |
effigies
reviewed
Jul 25, 2019
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
effigies
approved these changes
Jul 25, 2019
sappelhoff
approved these changes
Jul 25, 2019
|
merged! Thanks @franklin-feingold for the PR and everybody else for reviewing |
franklin-feingold
added a commit
that referenced
this pull request
Jul 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #257 and converted from this google doc
This is in the review phase and comment phase. I thought it could perhaps be easier to work and wrap up in this PR.