Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove excess test data from bidsschematools installation directories #1985

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

effigies
Copy link
Collaborator

Before

❯ du -sh dist/bidsschematools-0.11.3.post3.dev0*
2.7M	dist/bidsschematools-0.11.3.post3.dev0-py3-none-any.whl
1.8M	dist/bidsschematools-0.11.3.post3.dev0.tar.gz
❯ tar tf dist/bidsschematools-0.11.3.post3.dev0.tar.gz | wc -l
2662
❯ unzip -l dist/bidsschematools-0.11.3.post3.dev0-py3-none-any.whl | wc -l
2452

After

❯ du -sh dist/bidsschematools-0.11.3.post3.dev0*
208K	dist/bidsschematools-0.11.3.post3.dev0-py3-none-any.whl
1.8M	dist/bidsschematools-0.11.3.post3.dev0.tar.gz
❯ tar tf dist/bidsschematools-0.11.3.post3.dev0.tar.gz | wc -l
2675
❯ unzip -l dist/bidsschematools-0.11.3.post3.dev0-py3-none-any.whl | wc -l
139

Closes #1983.

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Nov 13, 2024
@effigies effigies added the schema-code Updates or changes to the code used to parse, filter, and render the schema. label Nov 13, 2024
@effigies effigies force-pushed the prune-bst-wheel branch 3 times, most recently from dc1074d to cc1eb76 Compare November 14, 2024 12:00
@Remi-Gau
Copy link
Collaborator

OK with me but quick question.

why not take the tests out of the codebase a well?

@effigies
Copy link
Collaborator Author

The goal right now is a minimal change to solve the immediate problem. We can be more radical in master.

@Remi-Gau
Copy link
Collaborator

ha yes, makes sense

merge at will then

@effigies effigies merged commit 9540a82 into bids-standard:maint/1.10.0 Nov 14, 2024
17 of 18 checks passed
@effigies effigies deleted the prune-bst-wheel branch November 14, 2024 12:56
@effigies
Copy link
Collaborator Author

Thanks!

@effigies
Copy link
Collaborator Author

@Remi-Gau This has been merged into master with appropriate adjustments to pyproject.toml: 6922930#diff-bdab2147910d68f1720eaedaa4ccf2db13a32406983c7279d57bce261e5e018a

Feel free to propose more comprehensive changes.

yarikoptic added a commit that referenced this pull request Nov 20, 2024
* origin/master: (288 commits)
  chore(deps): bump codecov/codecov-action from 4 to 5 (#1989)
  chore: Bump schema post-dev version
  schema-0.11.3.post3
  chore(ci): Fix pytest call for make_archive
  chore: Remove excess test data from bidsschematools installation directories (#1985)
  feat(cli): Add tool for filename validation for use in pre-receive hooks (#1986)
  rm COC (#1979)
  chore: Bump schema post-dev version
  schema-0.11.3.post2
  Update CONTRIBUTING.md (#1978)
  fix(schema): Check SliceTiming length against SliceEncodingDirection
  fix(schema): Do not warn about missing events for task-noise
  fix(schema): Check for existence of stim_files in beh.tsv
  chore: Use GITHUB_REF(_NAME) correctly
  chore: Debug environment
  chore: Bump schema post-dev version
  schema-0.11.3.post1
  chore: Output version, set correct env var
  chore: Update publish_schema to publish post-releases
  fix(schema): Include changes to schema that do not modify spec
  ...

 Conflicts:
	mkdocs.yml
	src/schema/objects/columns.yaml
	src/schema/objects/metadata.yaml
	src/schema/objects/modalities.yaml
	src/schema/objects/suffixes.yaml
	src/schema/rules/modalities.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants