-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add reference volumes to common imaging derivatives #1533
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1533 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
In the current proposal, the filename suffix is the concatenation of two items: some other pre-existing suffix indicating the contrast present in some other image, and "
|
The purpose of these volumes is for performing, applying and evaluating registrations. They do not map any particular physical quantity, they cannot necessarily be described as a voxel-wise summary statistic of the original series, and two tools generating references do not need to generate the same reference. They are useful for provenance and post-pipeline reuse. For example, when attempting to find a minimal set of derivatives needed to regenerate the rest, this is a critical one. I'm not sure if your position is that tools should not create these reference volumes, should have heterogeneous names that more closely reflect the contents, or should shove these files in
I wrote "A reference volume is a 3D image that is used to represent a 4D series," which is specifically not intended to indicate that the file was generated from the original 4D dataset or that the resulting contrast matches that suffix.
I think this derivative is both valuable and inextricable from processing.
That's not what
This is hyperbolic. There are currently 5 explicitly 4D suffixes ( I also don't see minimizing suffixes as an explicit goal so much as a heuristic for finding cases where a few suffixes and one or two entities might replace many suffixes. I have very little concern about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of reference volume suffixes makes sense to me.
Should Sources
be added as a RECOMMENDED metadata field? I know it's OPTIONAL for derivatives, but, as with masks, it seems particularly relevant for reference volumes.
In regards to concerns about adding suffixes, I do think that we generally want to avoid adding unnecessary suffixes when combinations of existing suffixes and entities would be sufficient, but in this case I think these reference volume suffixes are both useful and already widely in use. The only alternative I can think of would be a general reference
suffix, but that would just complicate things for a lot of tools.
Not entirely sure what the most precise terms are in all this.
Sorry for chiming in/if the above comment does not help in reaching an agreement. |
I would be fine with promoting it to RECOMMENDED.
Not sure that that's very useful here, as one process's static image is another process's moving. In the case of a boldref, it is static for motion correction and moving for coregistration. I really think "reference" is a useful term, as it is an image with a definite affine and grid that stands in for any other images that are aligned with it. Its contents need have no meaning apart from their usefulness in registration. If there's a more precise term for this type of image, I'm happy to use it, but it should not be dependent on the direction of registration. For what it's worth, the original inspiration for |
I do that. You may have noticed more generally. :-P I've had plenty of experience of blurring of logical concepts leading to problems in software design / communication, so will advocate for the cleanest separation even if the consequences of failing to do so aren't clear and won't manifest for years. But I have no expectation of always getting my way. Just trying to provide insights based on that experience and seeing which of them those of authority agree with.
I think refining this might provide some guidance / consensus. "Used to represent a series" is very vague.
"Static" and "moving" are best avoided here, since they imply an asymmetric registration, which is not always the case. That's also tying even more strongly to actual processing, as opposed to data content or even intent of processing, which I've expressed my objection to above. |
It was discovered that fmriprep, aslprep and qsiprep all generate
<suffix>ref
volumes for their respective input modalities. Here is an initial proposal. I do not think we need any additional metadata over the universally RECOMMENDEDDescription
and OPTIONALSources
.I kept
space-<label>
andres-<label>
but notden-<label>
, since these do make sense to resample into target spaces and possibly with resolutions differing from the input images, but there doesn't seem a clear analog for surface meshes. I suppose you could theoretically sample theboldref
to a surface as a diagnostic, but I figure we should let the use case come up before specifying it.Contradicting that, I threw
cbvref
in there, since it's functional data likebold
. I have no clue how that's processed, but it seems reasonable to say "if you want a reference file, call itcbvref
". In any case, there's nothing stopping modalities from adding another suffix that in practice they use as a reference volume. It is just useful to have a name for the thing that's not an actual average image but is some attempt to make a good registration target from what we are given.Closes #1532.