-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] clarify guiding principles for requirement levels #1444
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 14 14
Lines 1268 1268
=======================================
Hits 1116 1116
Misses 152 152 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Cross-posting from #1439:
|
Fair point that it has no effect on the interpretation, but it does add some context and may make it easier for readers to think about the requirement levels. Having that said, I am also not absolutely convinced that it HAS to go in the spec. As long as we have it somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have slight preference to have it in the spec if only because contributing if more contributors facing and less user facing.
I would say that this PR actually falls under the "interpretation" category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
closes #1422