-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INFRA: Drop numeric XX- from markdown file names #1332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh, I introduced merge conflicts by merging some PRs (I think). Sorry. +1 on merging this as soon as conflicts are resolved.
A potential re-ordering of sections can then follow in another PR that won't be as prone to conflicts.
|
Ah, I see one consequence of dropping the bids-specification/pdf_build_src/pandoc_script.py Lines 23 to 32 in 341a944
bids-specification/pdf_build_src/pandoc_script.py Lines 59 to 62 in 341a944
☝️ as can be seen in these snippets, the build was relying on the order being determined via the file names. but that doesn't explain why the CI fails (while locally, everything works, albeit with the screwed up ordering) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PDF build is broken (see comments above)
Seems this needs more thought. |
probably we could parse Line 52 in 6b09a66
... then we wouldn't need to have the loop that's dependent on file names, and we wouldn't have to maintain a duplicate list of files just for the PDF build I attempted this in #1343 ... perhaps merging that and pulling it into this branch would fix the build. |
Closes #1323.