Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCHEMA: Add index_columns metadata, render in tables #1306

Merged
merged 2 commits into from
Oct 10, 2022
Merged

SCHEMA: Add index_columns metadata, render in tables #1306

merged 2 commits into from
Oct 10, 2022

Conversation

effigies
Copy link
Collaborator

Closes #1304.

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. schema-code Updates or changes to the code used to parse, filter, and render the schema. exclude-from-changelog This item will not feature in the automatically generated changelog labels Sep 30, 2022
@effigies effigies force-pushed the schema/index_columns branch from e03fdf8 to 769c62e Compare September 30, 2022 12:39
bendhouseart
bendhouseart reviewed Sep 30, 2022
View reviewed changes
src/schema/README.md Outdated Show resolved Hide resolved
@effigies @bendhouseart
Update src/schema/README.md
a01b7ff 
Co-authored-by: Anthony Galassi <28850131+bendhouseart@users.noreply.github.com>
@effigies effigies force-pushed the schema/index_columns branch from eb3ad2b to a01b7ff Compare September 30, 2022 13:39
bendhouseart
bendhouseart approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@bendhouseart bendhouseart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

tsalo
tsalo approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm disappointed by the lack of an Oxford comma, but the changes look good to me otherwise. Thanks!

@effigies
Copy link
Collaborator Author

effigies commented Oct 4, 2022

I'm disappointed by the lack of an Oxford comma, but the changes look good to me otherwise. Thanks!

It's not clear we'll ever have three index columns, anyway.

@effigies effigies merged commit 1053ce4 into bids-standard:master Oct 10, 2022
@effigies effigies deleted the schema/index_columns branch October 10, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendhouseart bendhouseart bendhouseart approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

@tsalo tsalo tsalo approved these changes

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release. schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Primary keys / index columns in tabular metadata files
4 participants
@effigies @tsalo @sappelhoff @bendhouseart