Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Invert logic of bold onset hints #1300

Merged
merged 1 commit into from
Sep 24, 2022
Merged

[SCHEMA] Invert logic of bold onset hints #1300

merged 1 commit into from
Sep 24, 2022

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Sep 23, 2022

We only want to generate these messages when the check returns false.

We only want to generate these messages when the check returns false.
@rwblair rwblair requested review from effigies and removed request for erdalkaraca and tsalo September 23, 2022 17:43
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@66538fe). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1300   +/-   ##
=========================================
  Coverage          ?   88.57%           
=========================================
  Files             ?        6           
  Lines             ?     1042           
  Branches          ?        0           
=========================================
  Hits              ?      923           
  Misses            ?      119           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Sep 24, 2022
@effigies effigies merged commit a98ea74 into master Sep 24, 2022
@effigies effigies deleted the rwblair-patch-1 branch September 24, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants