-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add glossary links to all tables #1268
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1268 +/- ##
==========================================
+ Coverage 87.95% 88.30% +0.35%
==========================================
Files 6 6
Lines 1038 1052 +14
==========================================
+ Hits 913 929 +16
+ Misses 125 123 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The linking work in the recent PRs is really awesome @tsalo ... thanks a lot.
For other reviewers, checkout:
suffix tables, e.g., in anatomy imaging data:
metadata tables, e.g., in EEG: |
I think this should close #1053.
This PR updates the rendering functions to link tables to the glossary.
What this covers: