-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Use SPEC_ROOT/src_path in make_filename_template
#1248
Conversation
In the breaking build, internal links generated by With this fix, the |
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 6 6
Lines 1020 1020
=======================================
Hits 900 900
Misses 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
make_filename_template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my phone.
Cool. I'll merge it now and we'll see if it works! |
Seems to be working. |
Thanks for the quick fix! |
Closes None, but fixes an error introduced in #1228.
Changes proposed:
make_filename_template
.