Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ensures that metadata file have the same prefix as the queried file #195

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

Remi-Gau
Copy link
Collaborator

Fixes the issue of querying file with metadata files in the root directory (hence sometimes with no "_" before the suffix, like T1w.json) while still being able to query files with suffixes that might be part of another suffix: _thickness.json and midthickness.json.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #195 (37e2283) into dev (7f2a6a0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #195   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines        933     933           
=====================================
  Misses       933     933           
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
+bids/+internal/get_metadata.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2a6a0...37e2283. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 4caaea6 into bids-standard:dev Apr 16, 2021
Remi-Gau added a commit that referenced this pull request Apr 16, 2021
@Remi-Gau Remi-Gau deleted the remi_metadata branch May 23, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant