Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add another fNIRS example with finger/foot tapping during an automaticity task #317

Conversation

robertoostenveld
Copy link
Collaborator

this is a dataset that will be shared in full by @helenacockx on the Donders Repository.

See also #305 (comment)

@sappelhoff
Copy link
Member

sappelhoff commented Jun 20, 2022

Thanks Robert, but the first two commits seem to have "sneaked in" -- could you update the branch to only contain your NEW commits, please?

@robertoostenveld
Copy link
Collaborator Author

Sorry, I don't know how that happened, I though I started with master. I will start a new branch or revert these, and also get rid of the large pdf file.

@robertoostenveld
Copy link
Collaborator Author

Oh I see now, I should have started with bep030_nirs, not master

@sappelhoff
Copy link
Member

In that case, maybe this problem can also be solved by updating bep030_nirs

@robertoostenveld
Copy link
Collaborator Author

oops ...
I did not merge anything, I just removed the 4 commits to make my branch aligned with bep030_fnirs

@sappelhoff
Copy link
Member

yeah, I've had this problem before ... GitHub can close your branch when there are "no changes" (even if you intend to just clean up and then push the real work), I suspect that's what happened here.

robertoostenveld added a commit to robertoostenveld/bids-examples that referenced this pull request Jun 20, 2022
sappelhoff pushed a commit to robertoostenveld/bids-examples that referenced this pull request Sep 1, 2022
sappelhoff added a commit that referenced this pull request Sep 1, 2022
* added another example dataset for fNIRS, see #317

* use the nirs branch of the validator from rob-luke/bids-validator

* replaced "large" PDF file with a zero-byte version

* updated fNIRRS example dataset to pass the validator

 - fixed AnatomicalLandmarkCoordinateSy_t_em
 - fixed NIRSCoordinateUnit_e_s
 - removed txt from CHANGES
 - added stimulus MATLAB m-files to bidsignore
 - added sub-95 with n/a to practicelogbook.tsv
 - use n/a for empty cells in practicelogbook.tsv
 - added practicelogbook.tsv to bidsignore - HACK
 - removed sub-77 json files from sub-75/nirs directory
 - replaced 0-byte (empty) snirf files with 1-byte (still empty) snirf files - HACK
 - use forward slashes in scans.tsv
 - inserted "type" column in all optodes.tsv files
 - reordered the columns of channels.tsv

* renamed stim to stimuli

* added SourceType back to a JSON file where I accidentally deleted it

* revert validator branch change, add entry to README

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
sappelhoff added a commit that referenced this pull request Sep 1, 2022
* fNIRS example dataset (BEP030) (#305)

* Add fNIRS example dataset

* Use nirs branch for validator

* Update fnirs_tapping/dataset_description.json

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>

* Fix spacing in name

* revert link change validator

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>

* [ENH] New fNIRS example dataset: (non-)auto finger/foot tapping (#323)

* added another example dataset for fNIRS, see #317

* use the nirs branch of the validator from rob-luke/bids-validator

* replaced "large" PDF file with a zero-byte version

* updated fNIRRS example dataset to pass the validator

 - fixed AnatomicalLandmarkCoordinateSy_t_em
 - fixed NIRSCoordinateUnit_e_s
 - removed txt from CHANGES
 - added stimulus MATLAB m-files to bidsignore
 - added sub-95 with n/a to practicelogbook.tsv
 - use n/a for empty cells in practicelogbook.tsv
 - added practicelogbook.tsv to bidsignore - HACK
 - removed sub-77 json files from sub-75/nirs directory
 - replaced 0-byte (empty) snirf files with 1-byte (still empty) snirf files - HACK
 - use forward slashes in scans.tsv
 - inserted "type" column in all optodes.tsv files
 - reordered the columns of channels.tsv

* renamed stim to stimuli

* added SourceType back to a JSON file where I accidentally deleted it

* revert validator branch change, add entry to README

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>

Co-authored-by: Rob Luke <code@robertluke.net>
Co-authored-by: Robert Oostenveld <r.oostenveld@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants