Fix issues with eeg/ieeg/meg datasets. #197
Conversation
… a photo diode, PPG itself not on the allowed list of types
| @@ -76,5 +76,5 @@ GSR2 GSR n/a | |||
| Erg1 MISC n/a | |||
| Erg2 MISC n/a | |||
| Resp RESP n/a | |||
| Plet PPG n/a | |||
| Plet PD n/a | |||
There was a problem hiding this comment.
are you sure this is a photodiode @rwblair ? also tagging @arnodelorme to make him aware that the meditation dataset needs an update because the PPG "type" is not a valid type.
What kind of channel was that Arno?
There was a problem hiding this comment.
A PPG is not simply a photodiode. For a PD (as per IEEG specification) I would assume that the channel represents the signal of a photodiode that is attached to the corner of a screen. That is common in clinical iEEG experiments in EMUs (Epilepsy Monitoring Units), where screens used for stimuli are often not precisely calibrated.
Would it not be better to add PPG as an allowed type? I would say that a PPG channel is unambiguous. We also use them often for physio recordings during fMRI sessions.
There was a problem hiding this comment.
I have never used PPG but I am happy to follow your and @arnodelorme's lead here @robertoostenveld
bids-standard/bids-specification#561
A Pull Request is welcome, I'll be on vacation starting from tomorrow though.
| @@ -1,119 +1,119 @@ | |||
| name type units low_cutoff high_cutoff reference group status | |||
| 1 ECoG µV 300 0.5 intracranial 1 good | |||
There was a problem hiding this comment.
@dorahermes does this dataset need to be updated somewhere? i.e., the "real" dataset? --> just to keep the real data and the examples in sync
There was a problem hiding this comment.
We've only shared the non-BIDS version currently, we plan to put the BIDS data on openneuro. Will make sure to include these updates!
…ents use a photo diode, PPG itself not on the allowed list of types" This reverts commit b1cab51.
closes #186