Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsl default : [FIX] dead nodes #37

Merged
merged 6 commits into from
Oct 19, 2020
Merged

fsl default : [FIX] dead nodes #37

merged 6 commits into from
Oct 19, 2020

Conversation

remiadon
Copy link
Contributor

No description provided.

@remiadon remiadon linked an issue Oct 13, 2020 that may be closed by this pull request
FSL default v2 [3D][PR] #34
Closed
3 tasks
@remiadon
Copy link
Contributor Author

remiadon commented Oct 13, 2020 •
edited
Loading

@cmaumet seems OK for me
Here is the graph I get
fsl_default

  1. I updated the dead nodes, the graph seems OK, appart from the "copes.nii.gz" and "varcopes" entities, I believe they should be generated by the "stats" activity, and not by "registration" (see below)
    fsl_default

  2. I removed the notebook, I find it's deprecated, as everything has been wrapped in the CLI

  3. I provide 3 seperate .json,

  • "default.json" for the common parts
  • "group_analysis.json" for the ouputs of a group analysis
  • "single_subject_inference.json", for new estimation on a subject

@cmaumet
Copy link
Collaborator

cmaumet commented Oct 13, 2020

Thanks @remiadon. Hey: are we meeting now?

@remiadon remiadon merged commit c297118 into master Oct 19, 2020
@cmaumet cmaumet deleted the fsl_default_v2 branch April 26, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FSL default v2 [3D][PR]
2 participants
@remiadon @cmaumet