Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove fast-csv in favor of papaparse #490

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

schmanu
Copy link
Collaborator

@schmanu schmanu commented Feb 21, 2023

  • rewrites CSV parsing
  • remove chai and write testing specs in jest
  • update to react-scripts 5.0.2
  • add warning for invalid header names
  • remove console.logs

closes #436

- rewrites CSV parsing
- remove chai and write testing specs in jest
- remove console.logs
- add warning for invalid header names
@schmanu schmanu requested a review from bh2smith February 21, 2023 16:52
Copy link
Owner

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. No major issues that I could see, nice job! Just a few inline questions and comments.

@schmanu schmanu merged commit ad31bc7 into master Feb 23, 2023
@schmanu schmanu deleted the remove-fast-csv branch February 23, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react-scripts
2 participants