-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: pending tx status and donation button #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! I like the idea of putting a thank you somehow.
I also think we should include a section in the readme
Donate
Some blurb about us and open source along with the DONATE_ADDRESS
So far we have the same safe setup on Mainnet, Gnosis, Rinkeby, Goerli and not yet on Polygon (having trouble there). I would also be totally fine NOT deploying on Binance, cuz it sux. WDYT?
activeItemId={selectedToken || items[0].id} | ||
items={items} | ||
name={"Token"} | ||
label={"The token you want to donate"} | ||
onItemClick={setSelectedToken} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this like a drop down? Does it only show tokens that the safe holds a balance in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. It fetches the balances and generates the menu from that.
I will add the balances to the dropdown!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally fine with not supporting binance for now!
- fixes some bugs in status polling - refactors generate dialogs
Looks great to me! Only missing one checkbox on the todo list (I assume thats not gonna happen here). |
Open tasks