Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: pending tx status and donation button #437

Merged
merged 12 commits into from
Jul 26, 2022
Merged

Conversation

schmanu
Copy link
Collaborator

@schmanu schmanu commented Jul 15, 2022

Open tasks

Copy link
Owner

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I like the idea of putting a thank you somehow.

I also think we should include a section in the readme

Donate

Some blurb about us and open source along with the DONATE_ADDRESS

So far we have the same safe setup on Mainnet, Gnosis, Rinkeby, Goerli and not yet on Polygon (having trouble there). I would also be totally fine NOT deploying on Binance, cuz it sux. WDYT?

Comment on lines +92 to +96
activeItemId={selectedToken || items[0].id}
items={items}
name={"Token"}
label={"The token you want to donate"}
onItemClick={setSelectedToken}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this like a drop down? Does it only show tokens that the safe holds a balance in?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. It fetches the balances and generates the menu from that.
I will add the balances to the dropdown!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine with not supporting binance for now!

@bh2smith
Copy link
Owner

Looks great to me! Only missing one checkbox on the todo list (I assume thats not gonna happen here).

@schmanu schmanu changed the title add: donate button to add tx to csv add: pending tx status and donation button Jul 26, 2022
@schmanu schmanu merged commit 303b2e4 into master Jul 26, 2022
@schmanu schmanu deleted the add-donate-button branch July 26, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants