Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0 #155

Merged
merged 51 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
c600f3e
Bumping version to 4.5.33
bfren Oct 12, 2023
4dee0ef
Updating workflows
bfren Oct 12, 2023
34c7502
Bumping version to 5.0.0
bfren Oct 19, 2023
8531a4b
Switching to use nu
bfren Oct 20, 2023
a3fc349
Switching more to nu
bfren Oct 20, 2023
a7ad2c8
Improving version display
bfren Oct 20, 2023
ae5fd34
Renaming to BF_ASPNET_ASSEMBLY
bfren Oct 20, 2023
6ad9bb2
Enforcing LF line endings
bfren Oct 20, 2023
4350be0
Fixing -x prefix
bfren Oct 20, 2023
3860074
Adding ...args to service run file
bfren Oct 20, 2023
85a9297
Renaming fake dll
bfren Oct 20, 2023
bf9d768
Adding BF_DEBUG=1 to run.sh
bfren Oct 20, 2023
c7f260d
Add .NET version to build log
bfren Oct 21, 2023
57175d1
Switching beta and dev tags
bfren Oct 21, 2023
5e33b5c
Using new env module
bfren Oct 21, 2023
74287b7
Removing unnecessary TARGETPLATFORM from Dockerfile
bfren Oct 21, 2023
1b4719d
Using install add for dependencies
bfren Oct 21, 2023
255bcf9
Using full path to dotnet
bfren Oct 21, 2023
c0aad29
Using exec to run dotnet
bfren Oct 21, 2023
afcc1f0
Removing newline
bfren Oct 21, 2023
533d388
Use external executable for starting app
bfren Oct 21, 2023
058139b
Tweaking tar instructions
bfren Oct 21, 2023
60ff7fa
Set run.sh path temporarily
bfren Oct 21, 2023
a396c2c
Moving scripts to /etc/nu
bfren Oct 21, 2023
620a482
Saving ASPNET_RUNTIME variable
bfren Oct 21, 2023
41b78ee
Use new bf x as
bfren Oct 21, 2023
ab32645
Using new bf-s6 x as
bfren Oct 22, 2023
51814d8
Use full path to dotnet
bfren Oct 22, 2023
4b09128
Don't need full path to dotnet
bfren Oct 22, 2023
3c9cedb
Using bf-x-as
bfren Oct 22, 2023
9252d30
Disabling disagnostics
bfren Oct 23, 2023
de7e0a4
Try without disabling startup diagnostics
bfren Oct 23, 2023
fd7cef9
Running directly to reduce memory overheads
bfren Oct 23, 2023
6b43b95
Using new pkg module
bfren Oct 23, 2023
837cb60
Don't need environment variable when calling ch apply_file
bfren Oct 23, 2023
2ce8982
Using bf is_not_file
bfren Oct 24, 2023
f85fd78
Using env checker in healthcheck
bfren Oct 25, 2023
4cf8e0c
Updating to .NET 6.0.24 and 7.0.13
bfren Oct 25, 2023
df3f4cb
Fixing disable / restart functions
bfren Oct 25, 2023
8a5f9bd
Using new handle module
bfren Oct 27, 2023
1b6330e
Adding script namespace to handle
bfren Oct 28, 2023
706fcaf
Adding missing script namespace
bfren Oct 28, 2023
3e284db
Using new x_set override
bfren Nov 1, 2023
488291d
Adding bf-aspnet module to config
bfren Nov 8, 2023
a3f50b4
Refactoring Dockerfiles
bfren Nov 9, 2023
d20bbe3
Updating to .NET 6.0.25, 7.0.14 and 8.0.0
bfren Nov 18, 2023
47e54a3
Making .NET 8 the default run.sh version
bfren Nov 18, 2023
36e16f3
Don't override .NET 8 version string any more
bfren Nov 18, 2023
8684769
Adding support for installing arm/v7
bfren Nov 18, 2023
15e94ef
Adding armv7 builds
bfren Nov 18, 2023
9c2a2c8
Using released base images
bfren Nov 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Always use LF endings.
* text eol=lf
2 changes: 1 addition & 1 deletion .github/workflows/auto-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
steps:
-
name: Checkout Branch ${{ github.ref_name }}
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Create Pull Request
uses: bfren/pull-request@v2
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
steps:
-
name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
build:
strategy:
fail-fast: false
Expand All @@ -22,7 +22,7 @@ jobs:
steps:
-
name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Get repository name
run: echo "REPOSITORY_NAME=$(echo '${{ github.repository }}' | awk -F '/' '{print $2}')" >> $GITHUB_ENV
Expand All @@ -35,31 +35,31 @@ jobs:
id: version
-
name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
-
name: Login to DockerHub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
-
name: Build and push
id: docker_build
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: .
file: ./${{ matrix.dotnet }}/Dockerfile
build-args: |
BF_IMAGE=${{ env.REPOSITORY_NAME }}
BF_VERSION=${{ steps.version.outputs.contents }}
push: ${{ startsWith(github.ref, 'refs/heads/') }}
platforms: linux/amd64,linux/arm64
platforms: linux/amd64,linux/arm/v7,linux/arm64
tags: |
bfren/aspnet:net${{ matrix.dotnet }}-dev
bfren/aspnet:net${{ matrix.dotnet }}-${{ steps.version.outputs.contents }}-beta
bfren/aspnet:net${{ matrix.dotnet }}-${{ steps.version.outputs.contents }}-dev
-
name: Image digest
run: echo ${{ steps.docker_build.outputs.digest }}
12 changes: 6 additions & 6 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
-
name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Get repository name
run: echo "REPOSITORY_NAME=$(echo '${{ github.repository }}' | awk -F '/' '{print $2}')" >> $GITHUB_ENV
Expand Down Expand Up @@ -46,28 +46,28 @@ jobs:
id: version
-
name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
-
name: Login to DockerHub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
-
name: Build and push
id: docker_build
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: .
file: ./${{ matrix.dotnet }}/Dockerfile
build-args: |
BF_IMAGE=${{ env.REPOSITORY_NAME }}
BF_VERSION=${{ steps.version.outputs.contents }}
push: true
platforms: linux/amd64,linux/arm64
platforms: linux/amd64,linux/arm/v7,linux/arm64
tags: |
bfren/aspnet:net${{ matrix.dotnet }}
bfren/aspnet:net${{ matrix.dotnet }}-${{ steps.version_major.outputs.contents }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-readme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
shell: bash
-
name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to DockerHub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
Expand Down
22 changes: 6 additions & 16 deletions 6/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,39 +1,29 @@
FROM --platform=$BUILDPLATFORM golang:alpine AS build

ARG TARGETPLATFORM
ARG BUILDPLATFORM

RUN echo "Build: $BUILDPLATFORM, target: $TARGETPLATFORM" > /log

FROM bfren/alpine-s6:alpine3.18-4.5.9
COPY --from=build /log /log
FROM bfren/alpine-s6:alpine3.18-5.0.0

LABEL org.opencontainers.image.source="https://github.com/bfren/docker-aspnet"

ARG TARGETPLATFORM

ARG BF_IMAGE
ARG BF_VERSION

EXPOSE 5000

COPY ./overlay /
COPY ./6/overlay /

ENV \
# The ASP.NET version - used to assist in calculating checksums
ASPNET_VERSION=6 \
# Must be defined so the service can run the application
ASPNET_ASSEMBLY= \
# Configure web servers to bind to port 5000
ASPNETCORE_URLS="http://+:5000" \
# Must be defined so the service can run the application
BF_ASPNET_ASSEMBLY= \
# Otherwise it is set incorrectly to the S6 service directory
DOTNET_CONTENTROOT="/app/live" \
# Enable detection of running in a container
DOTNET_RUNNING_IN_CONTAINER=true \
# Set the invariant mode to false so CultureInfo can be used
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

COPY ./overlay /
COPY ./6/overlay /

RUN bf-install

VOLUME [ "/app/live", "/app/publish" ]
2 changes: 1 addition & 1 deletion 6/overlay/tmp/DOTNET_REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.0.23
6.0.25
22 changes: 6 additions & 16 deletions 7/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,39 +1,29 @@
FROM --platform=$BUILDPLATFORM golang:alpine AS build

ARG TARGETPLATFORM
ARG BUILDPLATFORM

RUN echo "Build: $BUILDPLATFORM, target: $TARGETPLATFORM" > /log

FROM bfren/alpine-s6:alpine3.18-4.5.9
COPY --from=build /log /log
FROM bfren/alpine-s6:alpine3.18-5.0.0

LABEL org.opencontainers.image.source="https://github.com/bfren/docker-aspnet"

ARG TARGETPLATFORM

ARG BF_IMAGE
ARG BF_VERSION

EXPOSE 5000

COPY ./overlay /
COPY ./7/overlay /

ENV \
# The ASP.NET version - used to assist in calculating checksums
ASPNET_VERSION=7 \
# Must be defined so the service can run the application
ASPNET_ASSEMBLY= \
# Configure web servers to bind to port 5000
ASPNETCORE_URLS="http://+:5000" \
# Must be defined so the service can run the application
BF_ASPNET_ASSEMBLY= \
# Otherwise it is set incorrectly to the S6 service directory
DOTNET_CONTENTROOT="/app/live" \
# Enable detection of running in a container
DOTNET_RUNNING_IN_CONTAINER=true \
# Set the invariant mode to false so CultureInfo can be used
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

COPY ./overlay /
COPY ./7/overlay /

RUN bf-install

VOLUME [ "/app/live", "/app/publish" ]
2 changes: 1 addition & 1 deletion 7/overlay/tmp/DOTNET_REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.0.12
7.0.14
22 changes: 6 additions & 16 deletions 8/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,39 +1,29 @@
FROM --platform=$BUILDPLATFORM golang:alpine AS build

ARG TARGETPLATFORM
ARG BUILDPLATFORM

RUN echo "Build: $BUILDPLATFORM, target: $TARGETPLATFORM" > /log

FROM bfren/alpine-s6:alpine3.18-4.5.9
COPY --from=build /log /log
FROM bfren/alpine-s6:alpine3.18-5.0.0

LABEL org.opencontainers.image.source="https://github.com/bfren/docker-aspnet"

ARG TARGETPLATFORM

ARG BF_IMAGE
ARG BF_VERSION

EXPOSE 5000

COPY ./overlay /
COPY ./8/overlay /

ENV \
# The ASP.NET version - used to assist in calculating checksums
ASPNET_VERSION=8 \
# Must be defined so the service can run the application
ASPNET_ASSEMBLY= \
# Configure web servers to bind to port 5000
ASPNETCORE_URLS="http://+:5000" \
# Must be defined so the service can run the application
BF_ASPNET_ASSEMBLY= \
# Otherwise it is set incorrectly to the S6 service directory
DOTNET_CONTENTROOT="/app/live" \
# Enable detection of running in a container
DOTNET_RUNNING_IN_CONTAINER=true \
# Set the invariant mode to false so CultureInfo can be used
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

COPY ./overlay /
COPY ./8/overlay /

RUN bf-install

VOLUME [ "/app/live", "/app/publish" ]
2 changes: 1 addition & 1 deletion 8/overlay/tmp/DOTNET_REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.0.0-rc.2
8.0.0
22 changes: 6 additions & 16 deletions Dockerfile.esh
Original file line number Diff line number Diff line change
@@ -1,39 +1,29 @@
FROM --platform=$BUILDPLATFORM golang:alpine AS build

ARG TARGETPLATFORM
ARG BUILDPLATFORM

RUN echo "Build: $BUILDPLATFORM, target: $TARGETPLATFORM" > /log

FROM bfren/alpine-s6:alpine<%= ${ALPINE_MINOR} %>-<%= ${BASE_REVISION} %>
COPY --from=build /log /log
FROM bfren/alpine-s6:alpine<%= ${ALPINE_MINOR} %>-<%= ${BASE_VERSION} %>

LABEL org.opencontainers.image.source="https://github.com/bfren/docker-aspnet"

ARG TARGETPLATFORM

ARG BF_IMAGE
ARG BF_VERSION

EXPOSE 5000

COPY ./overlay /
COPY ./<%= ${ASPNET_VERSION} %>/overlay /

ENV \
# The ASP.NET version - used to assist in calculating checksums
ASPNET_VERSION=<%= ${ASPNET_VERSION} %> \
# Must be defined so the service can run the application
ASPNET_ASSEMBLY= \
# Configure web servers to bind to port 5000
ASPNETCORE_URLS="http://+:5000" \
# Must be defined so the service can run the application
BF_ASPNET_ASSEMBLY= \
# Otherwise it is set incorrectly to the S6 service directory
DOTNET_CONTENTROOT="/app/live" \
# Enable detection of running in a container
DOTNET_RUNNING_IN_CONTAINER=true \
# Set the invariant mode to false so CultureInfo can be used
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

COPY ./overlay /
COPY ./<%= ${ASPNET_VERSION} %>/overlay /

RUN bf-install

VOLUME [ "/app/live", "/app/publish" ]
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.5.32
5.0.0
2 changes: 1 addition & 1 deletion VERSION_MAJOR
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4
5
2 changes: 1 addition & 1 deletion VERSION_MINOR
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.5
5.0
6 changes: 3 additions & 3 deletions generate-dockerfiles.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ set -euo pipefail

docker pull bfren/alpine

BASE_REVISION="4.5.9"
echo "Base: ${BASE_REVISION}"
BASE_VERSION="5.0.0"
echo "Base: ${BASE_VERSION}"

ASPNET_VERSIONS="6 7 8"
for V in ${ASPNET_VERSIONS} ; do
Expand All @@ -18,7 +18,7 @@ for V in ${ASPNET_VERSIONS} ; do
-e BF_DEBUG=0 \
bfren/alpine esh \
"/ws/Dockerfile.esh" \
BASE_REVISION=${BASE_REVISION} \
BASE_VERSION=${BASE_VERSION} \
ALPINE_MINOR=${ALPINE_MINOR} \
ASPNET_VERSION=${V}
)
Expand Down
2 changes: 1 addition & 1 deletion overlay/etc/bf/ch.d/10-aspnet
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/app/live www:www 0400 0500
/app/publish www:www 0660 0770
/app/publish www:www 0600 0700
18 changes: 0 additions & 18 deletions overlay/etc/bf/init.d/10-env

This file was deleted.

10 changes: 10 additions & 0 deletions overlay/etc/bf/init.d/10-env.nu
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
use bf
bf env load

# Set environment variables
def main [] {
let app = "/app"
bf env set ASPNET_APP $app
bf env set ASPNET_APP_LIVE $"($app)/live"
bf env set ASPNET_APP_PUBLISH $"($app)/publish"
}
Loading