[wip] csv dialect #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -170,7 +170,7 @@ def write(self): | |||
|
|
|||
| # void | |||
| def write_item(self, item): | |||
| raise extension.NotImplemented("{self}'s `write_item(item)` function is not implemented yet!" \ | |||
| raise exceptions.NotImplemented("{self}'s `write_item(item)` function is not implemented yet!" \ | |||
| import datetime | ||
| import unittest | ||
| import requests | ||
| import forcedtypes as t |
There was a problem hiding this comment.
Just a quick comment. Can you please remove the forcedtypes package dependency? I don't want to add it as a requirement to this library. You can copy the dp.SchemaFlow from here.
|
Furthermore, we need to keep it in mind to test this dialect under Windows as well. Probably it will be the most commonly used dialect. In mETL we have a recurring issue on that platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.