Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MGDSTRM-10786] Disable java-operator-sdk controller metrics by default #879

Merged
merged 1 commit into from
Mar 13, 2023
Merged

[MGDSTRM-10786] Disable java-operator-sdk controller metrics by default #879

merged 1 commit into from
Mar 13, 2023

Conversation

MikeEdgar
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the operator changes related to operator label Mar 9, 2023
@MikeEdgar
[MGDSTRM-10786] Disable java-operator-sdk controller metrics by default
de1b9ce 
Signed-off-by: Michael Edgar <medgar@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rareddy
Copy link
Contributor

rareddy commented Mar 9, 2023

what is the effect of this on any metrics that we may be capturing from this endpoint for management purposes?

@MikeEdgar
Copy link
Contributor Author

what is the effect of this on any metrics that we may be capturing from this endpoint for management purposes?

The operator will no longer store or return metrics in the operator_sdk_ prefix. I haven't found anywhere they are actually used for anything currently.

@MikeEdgar MikeEdgar marked this pull request as ready for review March 9, 2023 18:53
rareddy
rareddy approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

biswassri
biswassri approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shawkins
shawkins approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeEdgar MikeEdgar added this to the 0.35.0 milestone Mar 13, 2023
@MikeEdgar MikeEdgar merged commit d988a78 into bf2fc6cc711aee1a0c2a:main Mar 13, 2023
@MikeEdgar MikeEdgar deleted the MGDSTRM-10786 branch March 13, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@shawkins shawkins shawkins approved these changes

@biswassri biswassri biswassri approved these changes

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeEdgar @rareddy @shawkins @biswassri