addressing most severe sonar complaints

.github/workflows/sonar.yml

@@ -36,7 +36,7 @@ jobs:
 
       ## Retrieve the `target` directory from the build job
       - name: Fetch Build Result
-        uses: actions/github-script@v3.1.0
+        uses: actions/github-script@v6
         with:
           script: |
             var artifacts = await github.actions.listWorkflowRunArtifacts({

operator/src/main/java/org/bf2/operator/managers/SecuritySecretManager.java

@@ -31,6 +31,7 @@
 import java.util.stream.Stream;
 
 @ApplicationScoped
+@SuppressWarnings("java:S4790") // ignore weak hashing
 public class SecuritySecretManager {
 
     public static final String SASL_PRINCIPAL ="sasl.principal";

operator/src/main/java/org/bf2/operator/managers/StrimziBundleManager.java

@@ -255,16 +255,14 @@ private List<String> getStrimziVersions(Subscription subscription) {
                 .withName(subscription.getSpec().getName())
                 .get();
 
-        List<String> strimziVersions = this.strimziVersionsFromPackageManifest(packageManifest);
-        return strimziVersions;
-    }
-
-    private List<String> strimziVersionsFromPackageManifest(PackageManifest packageManifest) {
+        if (packageManifest == null) {
+            return Collections.emptyList();
+        }
         // avoiding the nullability of one of the status fields along the chain due to Kubernetes not updating
         // the PackageManifest on time when the fleetshard operator starts to take care of the approval
         // This way avoid a race condition raising an NPE
         String strimziVersionsJson =
-                Optional.ofNullable(packageManifest)
+                Optional.of(packageManifest)
                         .map(PackageManifest::getStatus)
                         .map(PackageManifestStatus::getChannels)
                         .map(packageChannels -> !packageChannels.isEmpty() ? packageChannels.get(0) : null)

operator/src/main/java/org/bf2/operator/mock/MockManagedKafkaFactory.java

@@ -37,6 +37,7 @@ public class MockManagedKafkaFactory {
     @Scheduled(every = "{mock.factory.interval}")
     void loop() {
 
+        @SuppressWarnings("java:S2245")
         Random random = new Random(System.currentTimeMillis());
         log.info("Mock ManagedKafka Factory:: Running Simulation");
 

operator/src/main/java/org/bf2/operator/operands/KafkaCluster.java

@@ -107,6 +107,7 @@
  */
 @ApplicationScoped
 @DefaultBean
+@SuppressWarnings("java:S4790") // ignore weak hashing
 public class KafkaCluster extends AbstractKafkaCluster {
 
     static final String KAS_FLEETSHARD_MEDIUM_PRIORITY = "kas-fleetshard-medium";

sync/src/main/java/org/bf2/sync/SecretManager.java

@@ -27,6 +27,7 @@
 import java.util.stream.Collectors;
 
 @ApplicationScoped
+@SuppressWarnings("java:S4790") // ignore weak hashing
 public class SecretManager {
 
     private static final String ENDPOINT_TLS_CRT = "endpoint.tls.crt";

sync/src/main/java/org/bf2/sync/controlplane/MockControlPlane.java

@@ -67,6 +67,7 @@ void loop() {
             return;
         }
 
+        @SuppressWarnings("java:S2245")
         Random random = new Random(System.currentTimeMillis());
         log.info("control plane:: Running Simulation");
 

sync/src/main/java/org/bf2/sync/informer/SecretRestartHandler.java

@@ -20,6 +20,7 @@
 @Startup
 @ApplicationScoped
 public class SecretRestartHandler {
+    @SuppressWarnings("java:S5852")
     private static final Pattern SECRET_PATTERN = Pattern.compile(".*\\[secret=[^/]*/[^/]*/([^/]*)/([^/]*)\\]");
 
     @Inject

systemtest/src/main/java/org/bf2/systemtest/api/sync/SyncApiClient.java

@@ -172,10 +172,11 @@ public static String getLatestAvailableKafkaVersion(Supplier<ManagedKafkaAgentSt
             ComparableVersion aVersion = new ComparableVersion(a);
             ComparableVersion bVersion = new ComparableVersion(b);
             return aVersion.compareTo(bVersion);
-        }).reduce((first, second) -> second).get();
+        }).reduce((first, second) -> second).orElseThrow();
     }
 
     public static Stream<String> sortedStrimziVersion(Stream<String> versions) {
+        @SuppressWarnings("java:S5852")
         Pattern pattern = Pattern.compile("^.*\\.v(?<version>[0-9]+\\.[0-9]+\\.[0-9]+[-0-9]*)$");
         return Objects.requireNonNull(versions.sorted((a, b) -> {
             Matcher aMatcher = pattern.matcher(a);

systemtest/src/main/java/org/bf2/systemtest/framework/SecurityUtils.java

@@ -68,6 +68,7 @@ public String getTrustStoreBase64() {
 
     }
 
+    @SuppressWarnings({"java:S2068", "java:S6437"})
     public static final String TRUSTSTORE_PASSWORD = "changeit";
 
     public static void main(String[] args) throws Exception {