Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGDSTRM-10764] Update Keycloak to version 21 for OpenShift 4.12 #873

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

MikeEdgar
Copy link
Contributor

@MikeEdgar MikeEdgar commented Mar 1, 2023

  • Bump Keycloak to version 21, adjust installation and supporting test code
  • Specify JUL log manager property for system tests - Quarkus 2.13.7 upgrade introduced very verbose OkHttp logging at INFO level, which is limited with this property
  • Remove surefire configuration to allow unit tests to be skipped when running with the quickly profile

Copy link
Contributor

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no chance to test it, but LGTM from code POV

@MikeEdgar MikeEdgar added this to the 0.35.0 milestone Mar 2, 2023
Signed-off-by: Michael Edgar <medgar@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikeEdgar
Copy link
Contributor Author

@biswassri @shawkins ok to merge this? The changes are entirely in the systemtest module.

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

static void awaitPodReady(String description, String labelName, String labelValue) {
TestUtils.waitFor(description + " ready", 1_000, 600_000, () -> isPodReady(labelName, labelValue));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a required change, but there is support in the client for operations like this.

TestUtils.waitFor(description + " ready", 1_000, 600_000, () -> isPodReady(labelName, labelValue));

and the isPodReady method can be replaced with

KubeClient.getInstance()
                .client()
                .pods()
                .inNamespace(OPERATOR_NS)
                .withLabel(labelName, labelValue)
                .waitUntilReady(600_000, TimeUnit.MILLISECONDS);

Most of the waitFor operations can be replaced in a similar manner as there is also waitUntilCondition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good suggestion. I opened #876 so we can remember to revisit this.

@MikeEdgar MikeEdgar merged commit 8d0fb66 into bf2fc6cc711aee1a0c2a:main Mar 3, 2023
@MikeEdgar MikeEdgar deleted the MGDSTRM-10764 branch March 3, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants