-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MGDSTRM-10764] Update Keycloak to version 21 for OpenShift 4.12 #873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have no chance to test it, but LGTM from code POV
Signed-off-by: Michael Edgar <medgar@redhat.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@biswassri @shawkins ok to merge this? The changes are entirely in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
|
||
static void awaitPodReady(String description, String labelName, String labelValue) { | ||
TestUtils.waitFor(description + " ready", 1_000, 600_000, () -> isPodReady(labelName, labelValue)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a required change, but there is support in the client for operations like this.
TestUtils.waitFor(description + " ready", 1_000, 600_000, () -> isPodReady(labelName, labelValue));
and the isPodReady method can be replaced with
KubeClient.getInstance()
.client()
.pods()
.inNamespace(OPERATOR_NS)
.withLabel(labelName, labelValue)
.waitUntilReady(600_000, TimeUnit.MILLISECONDS);
Most of the waitFor operations can be replaced in a similar manner as there is also waitUntilCondition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good suggestion. I opened #876 so we can remember to revisit this.
quickly
profile